This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
Feature/improve unit tests coverage #189
Merged
rutefig
merged 30 commits into
privacy-scaling-explorations:main
from
rutefig:feature/improve-unit-tests-coverage
Mar 21, 2024
Merged
Feature/improve unit tests coverage #189
rutefig
merged 30 commits into
privacy-scaling-explorations:main
from
rutefig:feature/improve-unit-tests-coverage
Mar 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #189 +/- ##
===========================================
+ Coverage 52.81% 64.31% +11.49%
===========================================
Files 26 26
Lines 7383 8078 +695
===========================================
+ Hits 3899 5195 +1296
+ Misses 3484 2883 -601 ☔ View full report in Codecov by Sentry. |
leolara
reviewed
Jan 15, 2024
leolara
reviewed
Jan 15, 2024
leolara
reviewed
Jan 15, 2024
leolara
reviewed
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check those comments
leolara
reviewed
Jan 27, 2024
leolara
reviewed
Jan 27, 2024
leolara
reviewed
Jan 27, 2024
leolara
reviewed
Jan 27, 2024
leolara
reviewed
Jan 27, 2024
leolara
reviewed
Jan 27, 2024
leolara
reviewed
Jan 27, 2024
@rutefig it has conflicts |
…fig/chiquito into feature/improve-unit-tests-coverage
leolara
reviewed
Mar 8, 2024
leolara
reviewed
Mar 8, 2024
leolara
reviewed
Mar 18, 2024
leolara
reviewed
Mar 18, 2024
leolara
approved these changes
Mar 21, 2024
@rutefig it is approved, but you need to fix clippy and rustfmt before merging |
Merged
via the queue into
privacy-scaling-explorations:main
with commit Mar 21, 2024
d139e1b
4 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added more unit tests to the following modules:
Covers some of these issues:
#157 #102 #105