Skip to content
This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

Feature/improve unit tests coverage #189

Conversation

rutefig
Copy link
Contributor

@rutefig rutefig commented Jan 14, 2024

Added more unit tests to the following modules:

  • poly
  • ast/query
  • dsl
  • dsl/cb
  • compiler/step_selector
  • compiler
  • super_circuit

Covers some of these issues:
#157 #102 #105

@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2024

Codecov Report

Attention: Patch coverage is 97.37188% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 64.31%. Comparing base (15f441b) to head (140e815).
Report is 1 commits behind head on main.

❗ Current head 140e815 differs from pull request most recent head 8ad9cc0. Consider uploading reports for the commit 8ad9cc0 to get more accurate results

Files Patch % Lines
src/frontend/dsl/mod.rs 88.29% 11 Missing ⚠️
src/frontend/dsl/sc.rs 96.19% 4 Missing ⚠️
src/poly/mod.rs 96.15% 4 Missing ⚠️
src/plonkish/ir/sc.rs 99.21% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #189       +/-   ##
===========================================
+ Coverage   52.81%   64.31%   +11.49%     
===========================================
  Files          26       26               
  Lines        7383     8078      +695     
===========================================
+ Hits         3899     5195     +1296     
+ Misses       3484     2883      -601     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rutefig
Copy link
Contributor Author

rutefig commented Jan 14, 2024

@leolara and @qwang98 can you review it please?

src/frontend/dsl/mod.rs Outdated Show resolved Hide resolved
src/plonkish/ir/sc.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@leolara leolara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check those comments

@rutefig rutefig requested a review from leolara January 20, 2024 15:19
src/frontend/dsl/mod.rs Outdated Show resolved Hide resolved
src/plonkish/ir/sc.rs Outdated Show resolved Hide resolved
src/poly/mod.rs Outdated Show resolved Hide resolved
src/sbpir/query.rs Outdated Show resolved Hide resolved
@rutefig rutefig marked this pull request as draft January 29, 2024 22:05
@leolara
Copy link
Collaborator

leolara commented Feb 26, 2024

@rutefig it has conflicts

@rutefig rutefig marked this pull request as ready for review March 4, 2024 18:57
@rutefig rutefig requested a review from leolara March 4, 2024 19:02
src/poly/mod.rs Outdated Show resolved Hide resolved
src/poly/mod.rs Outdated Show resolved Hide resolved
src/frontend/dsl/sc.rs Outdated Show resolved Hide resolved
@leolara
Copy link
Collaborator

leolara commented Mar 21, 2024

@rutefig it is approved, but you need to fix clippy and rustfmt before merging

@rutefig rutefig added this pull request to the merge queue Mar 21, 2024
Merged via the queue into privacy-scaling-explorations:main with commit d139e1b Mar 21, 2024
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants