Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Dropdown(#17039) Virtual Scroll Bug #17077

Closed
wants to merge 1 commit into from

Conversation

mark7p
Copy link
Contributor

@mark7p mark7p commented Dec 16, 2024

Closes #16868, closes #16991, closes #17007, closes #17031, closes #17039

Problem: The bug was introduced by #16979 (except for issue #16868)

if (simpleChanges.items) {
    this.setSpacerSize();
    this.setSize();
    this.cd.detectChanges();
}

Solution: Removed and fixed props update sequence for height and width.

Copy link

vercel bot commented Dec 16, 2024

@mark7p is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
primeng-v17 ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 11:23pm

@mertsincan
Copy link
Member

Thanks a lot for your contribution! But, this is related to v17 branch. For now, I ported your fix to v17 branch. Thanks a again!

@mertsincan mertsincan closed this Dec 17, 2024
@martinkasa
Copy link

@mertsincan the same problem with scroller is in v18 and probably v19 as well

@mark7p
Copy link
Contributor Author

mark7p commented Dec 19, 2024

hi @martinkasa, i just checked v18 and v19 and both are working fine. would you mind creating an issue and include reproduction of the bug?

@martinkasa
Copy link

martinkasa commented Dec 19, 2024

#17102 sorry, it could be not related to your original bug. I just noticed that all virtual scroll elements got broken in 17.18.12 and the same happens in v18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment