Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Dropdown(#17039) Virtual Scroll Bug #17044

Closed
wants to merge 9 commits into from

Conversation

mark7p
Copy link
Contributor

@mark7p mark7p commented Dec 13, 2024

Closes #16868, closes #16991, closes #17007, closes #17031, closes #17039

Problem: The bug was introduced by #16979

if (simpleChanges.items) {
    this.setSpacerSize();
    this.setSize();
    this.cd.detectChanges();
}

Solution: Removed and fixed props update sequence for height and width.

Copy link

vercel bot commented Dec 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
primeng-v17 ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 10:34pm

Copy link

vercel bot commented Dec 13, 2024

@mark7p is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@mark7p mark7p marked this pull request as draft December 13, 2024 10:14
@mark7p mark7p marked this pull request as ready for review December 13, 2024 10:25
@mark7p mark7p marked this pull request as draft December 13, 2024 10:27
@mark7p mark7p marked this pull request as ready for review December 13, 2024 10:34
@mark7p mark7p changed the title Fix: Dropdown(#17039) Virtual Scroll Bug Fix: Dropdown(#17039, #17039) Virtual Scroll Bug Dec 13, 2024
@mark7p mark7p changed the title Fix: Dropdown(#17039, #17039) Virtual Scroll Bug Fix: Dropdown(#17039) Virtual Scroll Bug Dec 13, 2024
@mertsincan mertsincan added the Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. label Dec 16, 2024
@mark7p mark7p marked this pull request as draft December 16, 2024 22:34
@mark7p mark7p closed this Dec 16, 2024
@mark7p mark7p deleted the fix/#17039-dropdown-bug branch December 16, 2024 22:41
@mark7p
Copy link
Contributor Author

mark7p commented Dec 16, 2024

please see new PR #17077

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated.
Projects
None yet
4 participants