FIX: Editor Module. ReferenceError: document is not defined. #8817 #14325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix seems to cause the following issue: #16825 Seems like the delayedCommand() call was removed in this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes #8817
This PR is enhancing changes made on PR #14232. During SSR build this issue #8817 still occurs.
So it seems the issue comes from importing quill on the top level, which somehow automatically initializes the instance of Quill.
So on this update, I have removed the import from the top level to dynamically import quill when it's in browser mode.
I also introduced afterNextRender because render callbacks never run during server-side rendering or build-time pre-rendering.