Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Editor Module SSR Compatibility #8817 #14232

Merged
merged 5 commits into from
Dec 6, 2023

Conversation

nejat-njonjo
Copy link
Contributor

Fixes issue #8817 .

When using SSR mode in Angular 17, EditorModule throws the following error

ERROR ReferenceError: document is not defined

so I have added a check, so it only creates a Quill instance when it's in browser mode.

Copy link

vercel bot commented Nov 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Nov 28, 2023 4:39pm

@nejat-njonjo nejat-njonjo changed the title Fix/ssr compatible on Editor Module Fix/ssr compatibility on Editor Module Nov 28, 2023
@nejat-njonjo nejat-njonjo changed the title Fix/ssr compatibility on Editor Module FIX: Editor Module SSR Compatibility #8817 Nov 28, 2023
Copy link

vercel bot commented Dec 6, 2023

@cetincakiroglu is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 6, 2023

Deployment failed with the following error:

The value for maxDuration must be between 1 second and 10 seconds, in order to increase this limit upgrade your plan: https://vercel.com/pricing

@cetincakiroglu cetincakiroglu merged commit 9e9af34 into primefaces:master Dec 6, 2023
1 of 3 checks passed
@Romain-Luengo
Copy link

Still not working on my side, do you have any ideas?

@nejat-njonjo
Copy link
Contributor Author

Still not working on my side, do you have any ideas?

Follow this PR, we can do a quick Google Meet to show u how I solved it.

#14325

@armingdev
Copy link

This error triggers again. Using Angular 17.1 with PrimeNG 17.5.

@Valya45
Copy link

Valya45 commented Feb 8, 2024

Please help, same issue angular 17 and primeng 17

@TodorKV
Copy link

TodorKV commented Feb 14, 2024

Has anyone found a work around ?

@nejat-njonjo
Copy link
Contributor Author

Has anyone found a work around ?

Checkout my second PR #14325. It fixes the issue. It hasn't been merged yet.

As of now you can just create it as a custom component.

@nejat-njonjo
Copy link
Contributor Author

Please help, same issue angular 17 and primeng 17

Checkout my second PR #14325. It fixes the issue. It hasn't been merged yet.

As of now you can just create it as a custom component.

@nejat-njonjo
Copy link
Contributor Author

This error triggers again. Using Angular 17.1 with PrimeNG 17.5.

Checkout my second PR #14325. It fixes the issue. It hasn't been merged yet.

As of now you can just create it as a custom component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants