Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #14160 Update confirmdialog.ts #14154

Closed
wants to merge 1 commit into from

Conversation

reramjiawan
Copy link

@reramjiawan reramjiawan commented Nov 20, 2023

Fix #14160 Use ng-container for templateOutlet since ng-template does not work!

Use ng-container for templateOutlet since ng-template does not work!
Copy link

vercel bot commented Nov 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2023 3:43pm

@SoyDiego
Copy link
Contributor

templateOutlet

Thanks for your contribution, Could you put the issue link that resolves this PR?. If is not exist, create one and then link this PR to the issue :)

@reramjiawan reramjiawan changed the title Update confirmdialog.ts Fix #14160 Update confirmdialog.ts Nov 21, 2023
@reramjiawan
Copy link
Author

templateOutlet

Thanks for your contribution, Could you put the issue link that resolves this PR?. If is not exist, create one and then link this PR to the issue :)

Done!

@SoyDiego
Copy link
Contributor

templateOutlet

Thanks for your contribution, Could you put the issue link that resolves this PR?. If is not exist, create one and then link this PR to the issue :)

Done!

Thanks but is not linked yet, you should add Fix #14160 editing your first message :) and you will see linked here:

image

@reramjiawan
Copy link
Author

templateOutlet

Thanks for your contribution, Could you put the issue link that resolves this PR?. If is not exist, create one and then link this PR to the issue :)

Done!

Thanks but is not linked yet, you should add Fix #14160 editing your first message :) and you will see linked here:

image

Hopefully I did it correctly now. Thanks for the approval!

@SoyDiego
Copy link
Contributor

templateOutlet

Thanks for your contribution, Could you put the issue link that resolves this PR?. If is not exist, create one and then link this PR to the issue :)

Done!

Thanks but is not linked yet, you should add Fix #14160 editing your first message :) and you will see linked here:
image

Hopefully I did it correctly now. Thanks for the approval!

Perfect, thanks!

@reramjiawan reramjiawan deleted the patch-1 branch November 22, 2023 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Component: ConfirmDialog
2 participants