Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: ConfirmDialog #14160

Closed
reramjiawan opened this issue Nov 21, 2023 · 1 comment
Closed

Component: ConfirmDialog #14160

reramjiawan opened this issue Nov 21, 2023 · 1 comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@reramjiawan
Copy link

reramjiawan commented Nov 21, 2023

Describe the bug

The ConfirmDialog supports customization through ng-templates. However when looking at the source code I noticed that not the correct element, ng-container, is used as the templateOutlet for several templates. I have created a PR that resolves this.

PR

PR

Reproducer

No response

Angular version

16.2.12

PrimeNG version

16.8.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20.x.x

Browser(s)

No response

Steps to reproduce the behavior

1.) use ngTemplate for ConfirmDialog message and you will notice it will not be rendered correctly once openend.

Expected behavior

Correct support for ngTemplate for all required elements inside ConfirmDialog

@reramjiawan reramjiawan added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 21, 2023
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants