Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Dropdown, AutoComplete, Listbox -virtualScroll UI issue #17007

Closed
petrov-ana opened this issue Dec 11, 2024 · 2 comments
Closed

Components: Dropdown, AutoComplete, Listbox -virtualScroll UI issue #17007

petrov-ana opened this issue Dec 11, 2024 · 2 comments
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team

Comments

@petrov-ana
Copy link

petrov-ana commented Dec 11, 2024

Describe the bug

In version 17.18.13, Basic dropdown, autocomplete, listbox work properly but if add [virtualScroll]="true" [virtualScrollItemSize]="38" then options not showing in expand panel. This issue is on primeNg offical website too. In version 17.18.12 there is no such problem
image
image
image

Environment

"@angular/common": "^17.3.0",
"primeng": "^17.18.13",

Reproducer

No response

Angular version

17.3.7

PrimeNG version

17.18.13

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.2

Browser(s)

Chrome 129.0.6668.71, Firefox 133.0.3

Steps to reproduce the behavior

  1. Add p-dropdown or p-autocomplte or p-listbox with virtualScroll
  2. On click of that expand panel is not visible properly.

Expected behavior

After click on dropdown or p-autocomplte with virtualScroll it should get expand properly for select options

@petrov-ana petrov-ana added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 11, 2024
@mertsincan mertsincan added this to the 17.18.14 milestone Dec 11, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 11, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 11, 2024
@LoaderB0T
Copy link
Contributor

Not sure if really related, but we also have an issue with virtual scrolling in the table control since v 17.18.13.
The "contentEl" in the scroller gets set initially to a div.p-scroller-content, which gets removed from the DOM afterwarts...
Results in a calculation of 0 visible items. So it might be related to this bug here.

@mertsincan mertsincan removed this from the 17.18.14 milestone Dec 17, 2024
@mertsincan mertsincan removed this from PrimeNG Dec 17, 2024
@mertsincan
Copy link
Member

Fixed in #17039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
3 participants