Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicDialog: Add support for focusOnShow (like Dialog component) #13768

Closed
mass4441 opened this issue Sep 28, 2023 · 0 comments · Fixed by #15263
Closed

DynamicDialog: Add support for focusOnShow (like Dialog component) #13768

mass4441 opened this issue Sep 28, 2023 · 0 comments · Fixed by #15263
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request

Comments

@mass4441
Copy link

Describe the feature you would like to see added

Add the possibilty to disable auto focus when DynamicDialog open with configuration.

Is your feature request related to a problem?

Some times i only have one button on my modal ( for example : close cross ) and the focus is automaticly set to it and it create focus css style to be triggered and look and feel is not good.

Describe the solution you'd like

Add a property to DynamicDialog configuration.
Like for Dialog component we can use focusOnShow property (default true).

Describe alternatives you have considered

I tried different workaround to disable the focus:

  • Hidding it with css
  • Creating a hidden button to catch the focus
  • Replacing the button with an anchor

But none of this solutions look clean to me. It would be better if we can disable this behaviour with a simple property.

Additional context

No response
@mass4441 mass4441 added Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request labels Sep 28, 2023
@mass4441 mass4441 mentioned this issue Sep 28, 2023
Closed
BGBRWR added a commit to BGBRWR/primeng that referenced this issue Apr 11, 2024
@BGBRWR
fix(primefaces#13162, primefaces#13768, primefaces#13082, primefaces#…
4522279 
…10472): dialog focuses on content on show
@BGBRWR BGBRWR mentioned this issue Apr 11, 2024
Merged
cetincakiroglu added a commit that referenced this issue Apr 18, 2024
@cetincakiroglu
Merge pull request #15263 from BGBRWR/issue-14010
c4163b7 
Fix #14010, #13162, #13768, #13082, #10472
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
No milestone
1 participant
@mass4441