Fix #14010, #13162, #13768, #13082, #10472

[BGBRWR]

fix #14010, fix #13162, fix #13768, fix #13082, fix #10472

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated (UTC)
primeng	⬜️ Ignored (Inspect)	Visit Preview		Apr 11, 2024 8:13pm

[cetincakiroglu]

Hi @BGBRWR

Thanks for fixing all these issues, we appreciate the effort and support!

[kevinley]

@cetincakiroglu @BGBRWR this PR introduced some unexpected behaviour. Now anything focusable inside the dialog gets focus, for instance I have a form inside a modal, where the first focusable element is a p-calendar, this opens the calendar overlay immediately, but we don't want that, because it covers other form elements.

Wether to focus the first focusable element within a dialog should be configurable with an option.

[dodesheide]

After this fix i run into errors with p-dialog and headless mode:

#15496

[BGBRWR]

@cetincakiroglu @BGBRWR this PR introduced some unexpected behaviour. Now anything focusable inside the dialog gets focus, for instance I have a form inside a modal, where the first focusable element is a p-calendar, this opens the calendar overlay immediately, but we don't want that, because it covers other form elements.

Wether to focus the first focusable element within a dialog should be configurable with an option.

You can set focusOnShow on the dialog to false.

[kevinley]

@cetincakiroglu @BGBRWR this PR introduced some unexpected behaviour. Now anything focusable inside the dialog gets focus, for instance I have a form inside a modal, where the first focusable element is a p-calendar, this opens the calendar overlay immediately, but we don't want that, because it covers other form elements.
Wether to focus the first focusable element within a dialog should be configurable with an option.

You can set focusOnShow on the dialog to false.

Tried that, doesn't work. Your code seems to ignore the flag

[rbbp23]

Another issue introduced by this PR.
On a dynamic dialog with a custom header and a footer template, I get a kind of infinite focus with the following error:

core.mjs:6531 ERROR RangeError: Maximum call stack size exceeded
at DomHandler.getFocusableElement (primeng-dom.mjs:553:31)
at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:592:36)
at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18)
at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18)
at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18)
at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18)
at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18)
at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18)
at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18)
at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18)

[TheWrightDev]

@rbbp23 Have you found any solution to this? This error completely breaks our ui ordering when it occurs, something weird happens with the z-index and things start appearing underneath random components on the page.

[BGBRWR]

Tried that, doesn't work. Your code seems to ignore the flag

You should create an issue with a stackblitz reproducing the bug because I'm not able to reproduce it myself.

[BGBRWR]

Another issue introduced by this PR. On a dynamic dialog with a custom header and a footer template, I get a kind of infinite focus with the following error:

core.mjs:6531 ERROR RangeError: Maximum call stack size exceeded at DomHandler.getFocusableElement (primeng-dom.mjs:553:31) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:592:36) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18)

Another issue introduced by this PR. On a dynamic dialog with a custom header and a footer template, I get a kind of infinite focus with the following error:

core.mjs:6531 ERROR RangeError: Maximum call stack size exceeded at DomHandler.getFocusableElement (primeng-dom.mjs:553:31) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:592:36) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18) at DynamicDialogComponent.focus (primeng-dynamicdialog.mjs:607:18)

You should create an issue with a stackblitz reproducing the bug because I'm not able to reproduce it myself.