Fix #13768 Add support of focusOnShow for DynamicDialog #13760
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
| @@ -161,6 +161,10 @@ export class DynamicDialogComponent implements AfterViewInit, OnDestroy { | |||
| return this.config.minY ? this.config.minY : 0; | |||
| } | |||
|
|
|||
| get focusOnShow(): boolean { | |||
| return this.config.focusOnShow ? this.config.focusOnShow : true; | |||
There was a problem hiding this comment.
I would like to suggest the line return this.config.focusOnShow ?? true;
And also you should edit your first post adding Fix #Number-Of-Issue-That-You-Are-Resolving and when PrimeNG Team approve it, will close automatically.
Thanks
There was a problem hiding this comment.
Thanks for feedback.
There's no issue created for this change. Is it mandatory to have one before creating a PR ?
There was a problem hiding this comment.
Yes please, if you can create the issue and link this PR to the issue will be great
Thanks for your contribution
mass4441
changed the title
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment, and we will keep it open. We are sorry that we have not been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
github-actions
bot
added
the
Resolution: Stale
|
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you for your understanding! |
Fix #13768
Currently focusOnShow is only available for DIalog, this PR add support of focusOnShow also for DynamicDialog