Unify parameter interface for solid solver #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidscn
changed the title
davidscn
commented
Mar 3, 2021
include/adapter/parameters.cc
Outdated
Comment on lines
59
to
62
| prm.add_parameter("Model", | ||
| model, | ||
| "Structural model to be used: linear or neo-Hook", | ||
| Patterns::Selection("linear|neo-Hook")); |
There was a problem hiding this comment.
Done. I added now an option here, where the user can select between the linear model and the neo-Hookean model. I hope this is intuitive enough, otherwise let me know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #50
This is a breaking change since we need to adjust the tutorial cases. However, I guess it is a good time due to the ongoing restructuring.