Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deal.II scripts #166

Merged
merged 9 commits into from
Mar 23, 2021
Merged

Update deal.II scripts #166

merged 9 commits into from
Mar 23, 2021

Conversation

davidscn
Copy link
Member

Related to precice/dealii-adapter#50 and precice/dealii-adapter#51.

@uekerman Now you have an example for the new version. I hope this helps in order to review the changes. In the dealii-adapter, please review first precice/dealii-adapter#51 and then precice/dealii-adapter#50.

Copy link
Member

@uekerman uekerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review includes precice/dealii-adapter#50 and precice/dealii-adapter#51

I did not check the code details, but the user side is nice. Much easier to handle now 👍
I was able to run linear and non-linear.
Only a few things we could document better in the parameters file.
(why is there a parameters.prm in the adapter repo?)

And the README of the adapter needs to be updated.

perpendicular-flap/solid-dealii/run.sh Outdated Show resolved Hide resolved
perpendicular-flap/solid-dealii/parameters.prm Outdated Show resolved Hide resolved
perpendicular-flap/solid-dealii/parameters.prm Outdated Show resolved Hide resolved
perpendicular-flap/solid-dealii/parameters.prm Outdated Show resolved Hide resolved
@davidscn
Copy link
Member Author

why is there a parameters.prm in the adapter repo?

It's needed to run a self created case.

And the README of the adapter needs to be updated.

Done.

@davidscn davidscn changed the title [WIP] Update deal.II scripts Update deal.II scripts Mar 21, 2021
@uekerman
Copy link
Member

why is there a parameters.prm in the adapter repo?

It's needed to run a self created case.

You could also point to the tutorials, right? In the end, it's just some code duplication, so another place to update when things change. Or what do you mean by self created case? You will always need another participant and a precice-config.xml, right?

@davidscn
Copy link
Member Author

why is there a parameters.prm in the adapter repo?

It's needed to run a self created case.

You could also point to the tutorials, right? In the end, it's just some code duplication, so another place to update when things change. Or what do you mean by self created case? You will always need another participant and a precice-config.xml, right?

hm The way I think of it is more a parameter file reference, similar to our xml reference. The cases in the tutorials are special configurations for a certain example. In fact, I could remove half of the parameters, where the nonlinear solver is not supposed to be used.

@davidscn davidscn merged commit 32bc673 into precice:develop Mar 23, 2021
@davidscn davidscn deleted the update-dealii branch March 23, 2021 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants