-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update deal.II scripts #166
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This review includes precice/dealii-adapter#50 and precice/dealii-adapter#51
I did not check the code details, but the user side is nice. Much easier to handle now 👍
I was able to run linear and non-linear.
Only a few things we could document better in the parameters file.
(why is there a parameters.prm
in the adapter repo?)
And the README of the adapter needs to be updated.
It's needed to run a self created case.
Done. |
You could also point to the tutorials, right? In the end, it's just some code duplication, so another place to update when things change. Or what do you mean by self created case? You will always need another participant and a |
hm The way I think of it is more a parameter file reference, similar to our xml reference. The cases in the tutorials are special configurations for a certain example. In fact, I could remove half of the parameters, where the nonlinear solver is not supposed to be used. |
Related to precice/dealii-adapter#50 and precice/dealii-adapter#51.
@uekerman Now you have an example for the new version. I hope this helps in order to review the changes. In the dealii-adapter, please review first precice/dealii-adapter#51 and then precice/dealii-adapter#50.