Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unsupported Velopack splash icon #29773

Conversation

smallketchup82
Copy link
Contributor

@smallketchup82 smallketchup82 commented Sep 7, 2024

Turns out that Velopack doesn't support transparent .png's as the splashicon, leading to issues like this on installation:
image

Velopack supports a:

  • High Resolution JPG
  • PNG with non-transparent background

This PR reuses https://github.com/ppy/osu/blob/master/osu.iOS/Assets.xcassets/AppIcon.appiconset/300076680-5cbe0121-ed68-414f-9ddc-dd993ac97e62.png for the icon. Though, alternative designs are welcome.

Preview:
image
You can use this release to test it (you must not have lazer installed first)

See ppy/osu-deploy#173 for testing details

@peppy peppy self-requested a review September 8, 2024 03:13
@peppy peppy added the next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! label Sep 9, 2024
@peppy
Copy link
Member

peppy commented Sep 9, 2024

@arflyte got anything to use here? if you can search up the specs required and provide something by wednesday that would be good.

@arflyte
Copy link

arflyte commented Sep 9, 2024

Not exactly sure what Velopack is. Made JPGs.

osu!cookie black BG
osu!Cookie RedGrey BG
osu!cookie white BG

Additionally, if it helps:

https://www.figma.com/design/9dyAxJqsNqwRIiAJMAxeko/osu!Cookie-v4b?node-id=0-1&t=rvYv91eIyBvg8IJA-1

@bdach
Copy link
Collaborator

bdach commented Sep 9, 2024

Velopack = installer.

That said we already have opaque icon stuff for mobile platforms: see https://github.com/ppy/osu/blob/master/osu.iOS/Assets.xcassets/AppIcon.appiconset/300076680-5cbe0121-ed68-414f-9ddc-dd993ac97e62.png. Maybe we can do the same here (as the OP already does) rather than non-descript single colour fill?

@arflyte
Copy link

arflyte commented Sep 9, 2024

What do you guys actually need. I humbly request context and I WILL provide the goods.

@bdach
Copy link
Collaborator

bdach commented Sep 9, 2024

We use an external tool to provide the game with an installer. It's called velopack. Currently it does this when launched (apology for janky video but it chooses itself to run on my primary monitor and I can't be bothered to change it just for this):

2024-09-09.22-25-12.mp4

It displays a splash window while it's silent-installing and the splash window looks terrible because it can't do transparency anymore (it used to). We need something better - non-transparent - to replace it. Notably probably with a bit of a gap underneath so that the progress bar can stop clipping the bottom of the logo. Also notably the docs claim animated GIFs are supported contrary to what the OP says but I did not test this myself at this time so I cannot verify the veracity of that claim.

Do note that we're not in control of the duration of display of the thing so it should probably be best to keep it a static image. Or if we wanna try animated then it should be like those "spinner"/"scrubber" style displays but osu!-themed probably. Maybe one of us should confirm whether GIF works first though to avoid a waste of time.

@arflyte
Copy link

arflyte commented Sep 10, 2024

Created 2 types of PNG, which rounded corners and sharp. And another with JPG. It's rectangle for stylistic purposes. It seems fairly quickly, so not sure if animated GIF is worth it.

The rounded corners has no gradient alpha channels, so try that one first, may fix the weird issues.

Velopack Rounded
Velopack Sharp
Velopack Sharp

@peppy
Copy link
Member

peppy commented Sep 10, 2024

Rounded corners obviously won't work. The bottom bar is not rounded.

@smallketchup82 want to test the very vertical images and see if they look good?

@smallketchup82
Copy link
Contributor Author

smallketchup82 commented Sep 10, 2024

Here's what it looks like with the vertically stretched version (also this is a windows 11 vm that's skinned to look like windows 7, sorry if it's a little misleading)
image

I think it's a bit too big, might be wise to scale it down a bit

@peppy
Copy link
Member

peppy commented Sep 10, 2024

I still think we can do better than just the osu logo. Some kind of loading text? Something special to make new users feel special? This just feels a bit of a cop-out.

@smallketchup82
Copy link
Contributor Author

If we don't want just a simple osu! logo, maybe we could draw from the fanart contests? Or do a contest specifically for the splash icon? That might be overkill for something that'll only display on windows, and will probably only show for 10 seconds, but it's an idea nevertheless. If I were a new player, I'd enjoy a cozy osu! themed drawing while installing.

@peppy
Copy link
Member

peppy commented Sep 11, 2024

@smallketchup82 is there a reason this PR isn't just opened at osu-deploy side? it doesn't seem that this resource needs to be over on this repository for any good reason.

@smallketchup82
Copy link
Contributor Author

Not really no, I was just doing as was done before. It should be completely fine to move the image to osu-deploy. Would you like me to do that when I have the time to?

@peppy
Copy link
Member

peppy commented Sep 11, 2024

I think it's probably best to have it in the same place it's being used, yeah. Less moving pieces for making modifications.

@smallketchup82
Copy link
Contributor Author

Will be closing this now, I'll move everything to this PR

@smallketchup82 smallketchup82 deleted the velopack-compatible-splashicon branch September 11, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:installer next release Pull requests which are almost there. We'll aim to get them in the next release, but no guarantees! size/XS type:cosmetic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants