Fix ugly installer splash screen #173
Merged
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smallketchup82
changed the title
|
Moved the file into osu-deploy. Not sure if we want it in an I'm still yet to test these changes, so I'll keep this PR as a draft until I do. |
|
Looks blurry to me:
|
|
It seems velopack doesn't handle high dpi displays correctly for the splash icon. |
peppy
changed the title
peppy
approved these changes
Sep 12, 2024
|
idk if i can place ideas out here, like in previous now closed pr, but if i can, i suggest to show some kind of artwork or something |
|
That's what I was hoping for. Just need to decide on the artwork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: ppy/osu#29773
Turns out that Velopack doesn't support transparent .png's as the splashicon, leading to issues like this on installation:
Velopack supports a:
This PR reuses https://github.com/ppy/osu/blob/master/osu.iOS/Assets.xcassets/AppIcon.appiconset/300076680-5cbe0121-ed68-414f-9ddc-dd993ac97e62.png for the icon. Though, alternative designs are welcome.
Preview:
You can use this release to test it (you must not have lazer installed first)
Testing Checklist
Works as expected for me!