Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove peak strain reduction #28844

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Remove peak strain reduction #28844

wants to merge 7 commits into from
+2 −23

Conversation

TextAdventurer12
Copy link

@TextAdventurer12 TextAdventurer12 commented Jul 13, 2024 •
edited
Loading

Stops reducing the peak strains in PP. Peak strain reduction is now less needed because combo scaling removal allows for a better balancing of most plays on these maps

This was referenced Jul 13, 2024
Closed
Draft
Draft
@frenzibyte frenzibyte requested a review from a team July 13, 2024 09:18
@TextAdventurer12 TextAdventurer12 marked this pull request as ready for review July 15, 2024 09:38
@smoogipoo
Copy link
Contributor

!diffcalc

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 16, 2024 •
edited
Loading

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/9950163812

@smoogipoo
Copy link
Contributor

!diffcalc

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 18, 2024 •
edited
Loading

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/9985738992

@smoogipoo
Copy link
Contributor

!diffcalc

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/10002753253

@smoogipoo
Copy link
Contributor

!diffcalc

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 19, 2024 •
edited
Loading

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/10004490955

stanriders
stanriders suggested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@stanriders stanriders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very misleading. I think a better way would be to make those fields abstract in OsuStrainSkill and make all skills inheriting it specify it explicitly.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Oct 3, 2024
@TextAdventurer12 TextAdventurer12 changed the title Strain reduction changes Remove peak strain reduction Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanriders stanriders stanriders requested changes

@apollo-dw apollo-dw apollo-dw approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:difficulty ruleset/osu! size/S
Projects
Difficulty calculation changes
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TextAdventurer12 @smoogipoo @stanriders @apollo-dw @frenzibyte