Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to performance calculation #28843

Closed
wants to merge 6 commits into from

Conversation

TextAdventurer12
Copy link

@TextAdventurer12 TextAdventurer12 commented Jul 13, 2024

This contains a change to length bonus to this curve, which generally nerfs longer maps, especially those greater than 2000 objects. There is also a nerf to the high AR bonus, and a small reduction to accuracy PP, as well as capping the accuracy length bonus at lower object count.

Values when combined with the other difficulty calculation changes (#28843 + #28844 + #28845 + #28846) can be seen here (onion access only)

Copy link
Member

@stanriders stanriders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TextAdventurer12 TextAdventurer12 marked this pull request as ready for review July 15, 2024 09:37
@smoogipoo
Copy link
Contributor

!diffcalc

Copy link

github-actions bot commented Jul 16, 2024

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/9949340967

@smoogipoo
Copy link
Contributor

!diffcalc

Copy link

github-actions bot commented Jul 18, 2024

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/9985738706

@smoogipoo
Copy link
Contributor

!diffcalc

Copy link

github-actions bot commented Jul 19, 2024

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/10002752864

@smoogipoo
Copy link
Contributor

!diffcalc

Copy link

github-actions bot commented Jul 19, 2024

Difficulty calculation failed: https://github.com/ppy/osu/actions/runs/10004490509

@TextAdventurer12
Copy link
Author

Closing this because what this aims to fix needs much better solutions and this just ends up tainting values

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants