Fix failing test #241
Merged
Fix failing test #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A test added in ppy#212, which was supposed to exercise the queue processor writing pp values back to legacy `scores_high` tables, is currently failing on master. The direct reason why is that `ScorePerformanceProcessor` is currently disabled for legacy scores as per ppy#212 (comment). This was required by ppy#239. The _indirect_ reason why this happened is that I cannot see CI test runs on _any_ of the commits authored by @tsunyoku in the PR, so there were never any tests run _to fail_. I'm not sure where _that_ comes from. May have something or other to do with first contribution to repository requiring maintainer approval for workflow runs. The test can be re-enabled once `osu-performance` decommissioning goes under way.
|
well, that sucks. I didn't even notice that CI never ran the tests on my PR... |
peppy
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test added in #212, which was supposed to exercise the queue processor writing pp values back to legacy
scores_hightables, is currently failing on master.The direct reason why is that
ScorePerformanceProcessoris currently disabled for legacy scores as per #212 (comment). This was required by #239.The indirect reason why this happened is that I cannot see CI test runs on any of the commits authored by @tsunyoku in the PR, so there were never any tests run to fail. I'm not sure where that comes from. May have something or other to do with first contribution to repository requiring maintainer approval for workflow runs.
The test can be re-enabled once
osu-performancedecommissioning goes under way.This also adds a warning comment for future travelers to reduce confusion as to why the envvar is doing nothing right now, and also renames the involved test in line with its actual expectations (which were changed in 4116beb without adjusting the test name).