Merge pull request #241 from bdach/fix-failing-test

Fix failing test
ppy · Mar 22, 2024 · e01bea6 · e01bea6
2 parents b0f65b0 + 1f17152
commit e01bea6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/osu.Server.Queues.ScoreStatisticsProcessor.Tests/PerformanceProcessorTests.cs b/osu.Server.Queues.ScoreStatisticsProcessor.Tests/PerformanceProcessorTests.cs
@@ -277,8 +277,8 @@ public void FailedScoreDoesNotProcess()
             });
         }
 
-        [Fact]
-        public void LegacyScoreDoesNotProcess()
+        [Fact(Skip = "ScorePerformanceProcessor is disabled for legacy scores for now: https://github.com/ppy/osu-queue-score-statistics/pull/212#issuecomment-2011297448.")]
+        public void LegacyScoreIsProcessedAndPpIsWrittenBackToLegacyTables()
         {
             AddBeatmap();
             AddBeatmapAttributes<OsuDifficultyAttributes>();

diff --git a/osu.Server.Queues.ScoreStatisticsProcessor/Processors/ScorePerformanceProcessor.cs b/osu.Server.Queues.ScoreStatisticsProcessor/Processors/ScorePerformanceProcessor.cs
@@ -161,6 +161,7 @@ public async Task ProcessScoreAsync(SoloScoreInfo score, MySqlConnection connect
                     Pp = performanceAttributes.Total
                 }, transaction: transaction);
 
+                // for the following code to take effect, `RunOnLegacyScores` must also be true (currently is false).
                 if (score.IsLegacyScore && write_legacy_score_pp)
                 {
                     var helper = LegacyDatabaseHelper.GetRulesetSpecifics(score.RulesetID);