-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement system-provided file selection display on iOS #6445
Conversation
@frenzibyte conflicts 🙏 |
Conflicts should be resolved. Also added minor iOS window API to do away with some of the awkward hookings and the sprinkled null forgiving operators everywhere in the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't have any major qualms with this, but will wait for another set of eyes i guess.
/// <summary> | ||
/// Interface representation of the game window on the iOS platform. | ||
/// </summary> | ||
public interface IIOSWindow : IWindow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is definitely an interface name.
I'll preface this with a warning that I'm not quite experienced in the world of UIKit, and the implementation in this PR came from a one/two-days of researching Apple's documentations. I'm still unsure about the way I'm disposing the view controller on
Dispose
but I don't sense any issues on real-world testing.This is implemented in a manner where if a
FileSelector
is loaded, it checks whether the platform supports system-based file selection, and hides the contents of theFileSelector
in favour of that.This is accompanied with osu!-side diff for the final behaviour shown in the video below.
osu!-side diff
Preview:
ScreenRecording_12-07-2024.04-17-13_1.mov