Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around Android CI workflow errors #6436

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Nov 28, 2024

Something extremely funny is happening straight from Windows Runner Image 20241113.3.0, where installing workloads without specifying a version installs ones from .NET 7(????)

This part should be enough to show how messed up the situation seems to be. The command execution shows that the used .NET SDK is correct, but the installed workloads point to .NET 7 versions. Moreover, the workload install output shows that it is installing both .NET 6 and .NET 7 versions of the workflow, which is just ??????

Fortunately, with the assumption that a workload manifest is published for every .NET SDK release, the pushed workaround which explicitly specifies the .NET SDK version we're using should hold enough until we move to .NET 9

Copy link
Member

@peppy peppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks to work

@peppy peppy requested a review from smoogipoo November 28, 2024 05:05
@smoogipoo smoogipoo merged commit abe67bb into ppy:master Nov 28, 2024
12 of 14 checks passed
@frenzibyte frenzibyte deleted the save-android branch November 28, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants