Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RearrangeableListContainer<> crashing on replacement operations #6424

Merged
merged 3 commits into from
Nov 14, 2024

Add another test for partial replace operation

69d1f7f
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Fix RearrangeableListContainer<> crashing on replacement operations #6424

Add another test for partial replace operation
69d1f7f
Select commit
Loading
Failed to load commit list.
GitHub Actions / Results failed Nov 14, 2024 in 0s

25179 passed, 1 failed and 636 skipped

Tests failed

Report Passed Failed Skipped Time
TestResults-Linux-MultiThreaded-Debug.trx 3147✅ 80⚪ 248s
TestResults-Linux-MultiThreaded-Release.trx 3147✅ 80⚪ 237s
TestResults-Linux-SingleThread-Debug.trx 3147✅ 80⚪ 198s
TestResults-Linux-SingleThread-Release.trx 3147✅ 80⚪ 157s
TestResults-macOS-MultiThreaded-Debug.trx 3147✅ 1❌ 79⚪ 739s
TestResults-macOS-SingleThread-Debug.trx 3148✅ 79⚪ 338s
TestResults-Windows-MultiThreaded-Debug.trx 3148✅ 79⚪ 281s
TestResults-Windows-SingleThread-Debug.trx 3148✅ 79⚪ 214s

✅ TestResults-Linux-MultiThreaded-Debug.trx

3227 tests were completed in 248s with 3147 passed, 0 failed and 80 skipped.

✅ TestResults-Linux-MultiThreaded-Release.trx

3227 tests were completed in 237s with 3147 passed, 0 failed and 80 skipped.

✅ TestResults-Linux-SingleThread-Debug.trx

3227 tests were completed in 198s with 3147 passed, 0 failed and 80 skipped.

✅ TestResults-Linux-SingleThread-Release.trx

3227 tests were completed in 157s with 3147 passed, 0 failed and 80 skipped.

❌ TestResults-macOS-MultiThreaded-Debug.trx

3227 tests were completed in 739s with 3147 passed, 1 failed and 79 skipped.

Test suite Passed Failed Skipped Time
osu.Framework.Tests.Visual.Drawables.TestSceneDelayedLoadWrapper 4✅ 1❌ 4s

❌ osu.Framework.Tests.Visual.Drawables.TestSceneDelayedLoadWrapper

✅ TestConstructor
✅ TestManyChildren(False)
✅ TestManyChildren(True)
✅ TestManyChildrenFunction(False)
❌ TestManyChildrenFunction(True)
	not too many loaded

✅ TestResults-macOS-SingleThread-Debug.trx

3227 tests were completed in 338s with 3148 passed, 0 failed and 79 skipped.

✅ TestResults-Windows-MultiThreaded-Debug.trx

3227 tests were completed in 281s with 3148 passed, 0 failed and 79 skipped.

✅ TestResults-Windows-SingleThread-Debug.trx

3227 tests were completed in 214s with 3148 passed, 0 failed and 79 skipped.

Annotations

Check failure on line 0 in TestResults-macOS-MultiThreaded-Debug.trx

See this annotation in the file changed.

@github-actions github-actions / Results

osu.Framework.Tests.Visual.Drawables.TestSceneDelayedLoadWrapper ► TestManyChildrenFunction(True)

Failed test found in:
  TestResults-macOS-MultiThreaded-Debug.trx
Error:
  not too many loaded
Raw output
not too many loaded
   at osu.Framework.Tests.Visual.Drawables.TestSceneDelayedLoadWrapper.TestManyChildrenFunction(Boolean instant) in /Users/runner/work/osu-framework/osu-framework/osu.Framework.Tests/Visual/Drawables/TestSceneDelayedLoadWrapper.cs:line 144
   at InvokeStub_TestSceneDelayedLoadWrapper.TestManyChildrenFunction(Object, Span`1)