Update existing test coverage

ppy · Oct 25, 2024 · e5562f4 · e5562f4
1 parent 7862073
commit e5562f4
Showing 1 changed file with 16 additions and 4 deletions.
diff --git a/osu.Framework.Tests/Visual/Input/TestSceneKeyBindingContainer.cs b/osu.Framework.Tests/Visual/Input/TestSceneKeyBindingContainer.cs
@@ -116,6 +116,11 @@ public void TestPressKeyBeforeKeyBindingContainerAdded()
             AddAssert("ActionA released", () => releasedActions[0], () => Is.EqualTo(TestAction.ActionA));
         }
 
+        /// <summary>
+        /// Unlike <see cref="TestPressKeyBeforeKeyBindingContainerAdded"/>, when an intermediate input manager is involved,
+        /// we expect the key binding container to be fed with any previously pressed key
+        /// (consider an osu!catch player pressing the left/right/dash keys before entering gameplay).
+        /// </summary>
         [Test]
         public void TestPressKeyBeforeKeyBindingContainerAdded_WithPassThroughInputManager()
         {
@@ -142,15 +147,22 @@ public void TestPressKeyBeforeKeyBindingContainerAdded_WithPassThroughInputManag
                 };
             });
 
+            AddAssert("only one action pressed", () => pressedActions, () => Has.Count.EqualTo(1));
+            AddAssert("ActionEnter pressed", () => pressedActions[0], () => Is.EqualTo(TestAction.ActionEnter));
+            AddAssert("no actions released", () => releasedActions, () => Is.Empty);
+
             AddStep("press key A", () => InputManager.PressKey(Key.A));
-            AddAssert("only one action triggered", () => pressedActions, () => Has.Count.EqualTo(1));
-            AddAssert("ActionA triggered", () => pressedActions[0], () => Is.EqualTo(TestAction.ActionA));
+            AddAssert("two actions pressed", () => pressedActions, () => Has.Count.EqualTo(2));
+            AddAssert("ActionA pressed", () => pressedActions[1], () => Is.EqualTo(TestAction.ActionA));
             AddAssert("no actions released", () => releasedActions, () => Is.Empty);
 
             AddStep("release key A", () => InputManager.ReleaseKey(Key.A));
-            AddAssert("only one action triggered", () => pressedActions, () => Has.Count.EqualTo(1));
-            AddAssert("only one action released", () => releasedActions, () => Has.Count.EqualTo(1));
+            AddAssert("one action released", () => releasedActions, () => Has.Count.EqualTo(1));
             AddAssert("ActionA released", () => releasedActions[0], () => Is.EqualTo(TestAction.ActionA));
+
+            AddStep("release enter", () => InputManager.ReleaseKey(Key.Enter));
+            AddAssert("two actions released", () => releasedActions, () => Has.Count.EqualTo(2));
+            AddAssert("ActionEnter released", () => releasedActions[1], () => Is.EqualTo(TestAction.ActionEnter));
         }
 
         [Test]