Selectively opt-in some usage rules

ppy · Nov 27, 2024 · b723add · b723add
1 parent 3887b9b
commit b723add
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/.globalconfig b/.globalconfig
@@ -84,8 +84,11 @@ dotnet_diagnostic.CA2101.severity = none
 # CA2201: Do not raise reserved exception types
 dotnet_diagnostic.CA2201.severity = warning
 
-#Disable operator overloads requiring alternate named methods
-dotnet_diagnostic.CA2225.severity = none
+# CA2208: Instantiate argument exceptions correctly
+dotnet_diagnostic.CA2208.severity = warning
+
+# CA2242: Test for NaN correctly
+dotnet_diagnostic.CA2242.severity = warning
 
 # Banned APIs
 dotnet_diagnostic.RS0030.severity = error
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -37,6 +37,8 @@
     <AnalysisModeNaming>Default</AnalysisModeNaming>
     <AnalysisModePerformance>Minimum</AnalysisModePerformance>
     <AnalysisModeReliability>Recommended</AnalysisModeReliability>
+    <AnalysisModeSecurity>Default</AnalysisModeSecurity>
+    <AnalysisModeUsage>Default</AnalysisModeUsage>
   </PropertyGroup>
   <PropertyGroup Label="NuGet">
     <Authors>ppy Pty Ltd</Authors>

diff --git a/osu.Framework/Graphics/Rendering/Deferred/DeferredVertexBatch.cs b/osu.Framework/Graphics/Rendering/Deferred/DeferredVertexBatch.cs
@@ -54,7 +54,7 @@ public DeferredVertexBatch(DeferredRenderer renderer, PrimitiveTopology topology
                         throw new NotImplementedException($"Topology '{topology}' is not yet implemented for this renderer.");
 
                     default:
-                        throw new ArgumentOutOfRangeException();
+                        throw new ArgumentOutOfRangeException(nameof(topology));
                 }
             }
             else