-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PLAY-1742] Global Height Fixes #3972
Conversation
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.9.0.pre.alpha.play1742globalheightfixes4766 Your Alpha for NPM is 14.9.0-alpha.play1742globalheightfixes4766 |
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.9.0.pre.alpha.play1742globalheightfixes4925 Your Alpha for NPM is 14.9.0-alpha.play1742globalheightfixes4925 |
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.9.0.pre.alpha.play1742globalheightfixes4926 Your Alpha for NPM is 14.9.0-alpha.play1742globalheightfixes4926 |
You merged this pr to master branch: |
What does this PR do? A clear and concise description with your runway ticket url.
Runway https://runway.powerhrg.com/backlog_items/PLAY-1742
Our global height prop doesn't work the way we were expecting for some of our kits
Examples of how we should use them are here https://codesandbox.io/p/sandbox/global-height-props-forked-wfc9vf
Layout.Body
Layout.Side
and the othersBecause the table kit is really just a bunch of styles