Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1742] Global Height Fixes #3972

Merged
merged 3 commits into from
Dec 19, 2024
Merged

Conversation

markdoeswork
Copy link
Contributor

@markdoeswork markdoeswork commented Dec 4, 2024

What does this PR do? A clear and concise description with your runway ticket url.
Runway https://runway.powerhrg.com/backlog_items/PLAY-1742

Our global height prop doesn't work the way we were expecting for some of our kits

Examples of how we should use them are here https://codesandbox.io/p/sandbox/global-height-props-forked-wfc9vf

  • Layout
    • Add global props the the children kits Layout.Body Layout.Side and the others
  • Collapsible
    • Uses height to show and hide content i think it would be dangerous to change, just wrap the entire thing in a container with overflow and height
  • Drawer
    • I fixed it
  • Overlay
    • Works is just weird
  • Section Separator
    • Just weird
  • Table
    • Max height needs to be wrapped in a container. Could add an "inline size" that removes a lot of our padding and other styles.
      Because the table kit is really just a bunch of styles
  • Flex Items
    • Weird

@markdoeswork markdoeswork added milano 20 MAX - Deploy this PR to a review environment via Milano alpha minor Semver Target labels Dec 4, 2024
@markdoeswork markdoeswork self-assigned this Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.9.0.pre.alpha.play1742globalheightfixes4766

Your Alpha for NPM is 14.9.0-alpha.play1742globalheightfixes4766

@markdoeswork markdoeswork marked this pull request as ready for review December 5, 2024 14:41
@markdoeswork markdoeswork requested a review from a team as a code owner December 5, 2024 14:41
@jasperfurniss jasperfurniss added Code Approved Approved by a Playbook Admin and removed Needs Review labels Dec 6, 2024
@nidaqg nidaqg added Product Approved pending technical review, OK to merge to master Ready for Release merged to master, ready for a versioned released labels Dec 10, 2024
@jasperfurniss jasperfurniss removed the Ready for Release merged to master, ready for a versioned released label Dec 12, 2024
@markdoeswork markdoeswork added alpha and removed alpha labels Dec 16, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.9.0.pre.alpha.play1742globalheightfixes4925

Your Alpha for NPM is 14.9.0-alpha.play1742globalheightfixes4925

Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.9.0.pre.alpha.play1742globalheightfixes4926

Your Alpha for NPM is 14.9.0-alpha.play1742globalheightfixes4926

@jasperfurniss jasperfurniss merged commit 8543aa2 into master Dec 19, 2024
8 checks passed
@jasperfurniss jasperfurniss deleted the play/1742_global_height_fixes branch December 19, 2024 13:35
Copy link

You merged this pr to master branch:
- Ruby Gem: 14.10.0.pre.rc.17
- NPM: 14.10.0-rc.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Code Approved Approved by a Playbook Admin milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants