-
Notifications
You must be signed in to change notification settings - Fork 15
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[PLAY-1742] Global Height Fixes (#3972)
**What does this PR do?** A clear and concise description with your runway ticket url. Runway https://runway.powerhrg.com/backlog_items/PLAY-1742 Our global height prop doesn't work the way we were expecting for some of our kits Examples of how we should use them are here https://codesandbox.io/p/sandbox/global-height-props-forked-wfc9vf - Layout - Add global props the the children kits `Layout.Body` `Layout.Side` and the others - Collapsible - Uses height to show and hide content i think it would be dangerous to change, just wrap the entire thing in a container with overflow and height - Drawer - I fixed it - Overlay - Works is just weird - Section Separator - Just weird - Table - Max height needs to be wrapped in a container. Could add an "inline size" that removes a lot of our padding and other styles. Because the table kit is really just a bunch of styles - Flex Items - Weird
- Loading branch information
1 parent
bd9f07c
commit 8543aa2
Showing
2 changed files
with
32 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters