Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1673] Dark Mode Audit - Caption and Title #3961

Merged
merged 3 commits into from
Dec 9, 2024
Merged

[PLAY-1673] Dark Mode Audit - Caption and Title #3961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07a2161
Add dark mode colors for titles
Lsimmons98 Nov 27, 2024
51132ae
add dark mode colors for captions
Lsimmons98 Nov 27, 2024
604476d
Move dark colors from token file to title_mixin file
Lsimmons98 Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion playbook/app/pb_kits/playbook/pb_caption/_caption_mixin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,10 @@ $pb_caption_colors: (
$pb_dark_caption_colors: (
default: $text_dk_default,
light: $text_dk_light,
lighter: $text_dk_lighter,
link: $active_dark,
success: $text_dk_success_sm,
error: $error,
error: $error_dark,
);


Expand Down
11 changes: 6 additions & 5 deletions playbook/app/pb_kits/playbook/pb_title/_title.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,11 @@
}

&.dark {
@include pb_title_dark;
}

&.dark[class*=_link] {
@include pb_title_dark_link;
@include title_dark;
@each $name, $color in $pb_dark_title_colors {
&[class*="_#{$name}"] {
color: $color;
}
}
}
}
13 changes: 13 additions & 0 deletions playbook/app/pb_kits/playbook/pb_title/_title_mixin.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,23 @@ $pb_title_colors: (
link: $primary
);

$pb_dark_title_colors: (
default: $text_dk_default,
light: $text_dk_light,
lighter: $text_dk_lighter,
success: $success,
error: $error_dark,
link: $active_dark
);

@mixin title_colors {
@each $name, $color in $pb_title_colors {
&[class*=_#{$name}] {
color: $color
}
}
}

@mixin title_dark {
color: $text_dk_default;
}
8 changes: 0 additions & 8 deletions playbook/app/pb_kits/playbook/tokens/_titles.scss
View file
Open in desktop
kangaree marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,6 @@
@include pb_title($heading_4, $bolder, $letterSpacing: $lspace_normal);
}

@mixin pb_title_dark {
color: $text_dk_default;
}

@mixin pb_title_dark_link {
color: $active_dark;
}

@mixin pb_title_bold {
font-weight: $bolder;
}
Expand Down
Loading