Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1673] Dark Mode Audit - Caption and Title #3961

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

Lsimmons98
Copy link
Contributor

@Lsimmons98 Lsimmons98 commented Nov 27, 2024

What does this PR do? A clear and concise description with your runway ticket url.

Updates to dark mode styling based on audit for the Caption and Title components.

PLAY-1673

Screenshots: Screenshots to visualize your addition/change

Screenshot 2024-11-27 at 3 01 20 PM  THIS ONE Screenshot 2024-11-27 at 3 12 37 PM

How to test? Steps to confirm the desired behavior:

  1. Go to 'kits/title'
  2. Scroll down to 'Colors' -- Title colors should now be dark mode compatible
  3. Go to 'kits/caption
  4. Scroll down to 'Colors' -- Caption colors should now be dark mode compatible

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.

@Lsimmons98 Lsimmons98 added milano 20 MAX - Deploy this PR to a review environment via Milano improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) minor Semver Target labels Nov 27, 2024
@Lsimmons98 Lsimmons98 self-assigned this Nov 27, 2024
@Lsimmons98 Lsimmons98 requested a review from a team as a code owner November 27, 2024 21:01
kangaree
kangaree previously approved these changes Dec 4, 2024
nidaqg
nidaqg previously approved these changes Dec 5, 2024
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Dec 5, 2024
@Lsimmons98 Lsimmons98 dismissed stale reviews from nidaqg and kangaree via 544ec1d December 6, 2024 17:05
@Lsimmons98 Lsimmons98 force-pushed the play-1673-dark-mode-audit branch from 544ec1d to 604476d Compare December 6, 2024 18:23
@Lsimmons98
Copy link
Contributor Author

Pushed changes from another story and had to remove the commits from this branch so we need an updated code review here.

@jasperfurniss jasperfurniss merged commit 52c84d4 into master Dec 9, 2024
8 checks passed
@jasperfurniss jasperfurniss deleted the play-1673-dark-mode-audit branch December 9, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants