Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLAY-1549] Update react modal version #3819

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

markdoeswork
Copy link
Contributor

@markdoeswork markdoeswork commented Oct 17, 2024

What does this PR do? A clear and concise description with your runway ticket url.
Runway https://runway.powerhrg.com/backlog_items/PLAY-1549

This is just a story to upgrade react-modal, because we want to keep things up to date

There are no major updates if you look at the commits its mostly bug fixes https://github.com/reactjs/react-modal/commits/master/

There are no issues i've encountered in personal regression testing

I made a nitro Alpha https://github.com/powerhome/nitro-web/pull/43287

@markdoeswork markdoeswork changed the title [PLAY-1549]Update react version [PLAY-1549] Update react version Oct 17, 2024
@markdoeswork markdoeswork self-assigned this Oct 17, 2024
@markdoeswork markdoeswork added milano 20 MAX - Deploy this PR to a review environment via Milano alpha labels Oct 17, 2024
Copy link

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.5.0.pre.alpha.play1549upgradereactmodal4130

Your Alpha for NPM is 14.5.0-alpha.play1549upgradereactmodal4130

@markdoeswork markdoeswork changed the title [PLAY-1549] Update react version [PLAY-1549] Update react modal version Oct 18, 2024
@markdoeswork markdoeswork marked this pull request as ready for review October 18, 2024 13:09
@markdoeswork markdoeswork requested review from a team as code owners October 18, 2024 13:09
@nidaqg nidaqg added Product Approved pending technical review, OK to merge to master Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) labels Oct 22, 2024
@nidaqg nidaqg added this pull request to the merge queue Oct 22, 2024
Merged via the queue into master with commit bd2066e Oct 22, 2024
10 checks passed
@nidaqg nidaqg deleted the play/1549_upgrade_react_modal branch October 22, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha Code Approved Approved by a Playbook Admin improvement This is used when your PR contains library upgrades or doc/site improvements. (USED IN CHANGELOG)) milano 20 MAX - Deploy this PR to a review environment via Milano Product Approved pending technical review, OK to merge to master
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants