Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-7615: Adding isSyncedBackup flag to identify the synced backups #258

Closed
wants to merge 2 commits into from
Closed

PB-7615: Adding isSyncedBackup flag to identify the synced backups #258

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d9bebf
PB-7615: staticcheck error fix
shkumari-px Aug 30, 2024
4a2aade
PB-7615: Adding isSyncedBackup flag to identify the synced backups
shkumari-px Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Do not use directly, use `make docker-build-proto` instead
#

FROM golang:1.20
FROM golang:1.23
ENV GOPATH=/go
RUN mkdir -p portworx/px-backup-api
WORKDIR portworx/px-backup-api
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ vet:
go vet $(PKGS)

staticcheck:
GOFLAGS="" go install honnef.co/go/tools/cmd/staticcheck@v0.4.7
GOFLAGS="" go install honnef.co/go/tools/cmd/staticcheck@latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason why we are changing this? Because as per I remember when it was 'latest' it was giving error while building docker image due to which we had given a specific version.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 please confirm if we have to use latest or 0.4.7

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-02 at 12 07 44 PM Go version 1.23 with staticcheck version 0.4.7 still gives error

staticcheck $(PKGS)

errcheck:
Expand Down
Loading
Loading