PB-7615: Adding isSyncedBackup flag to identify the synced backups #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OSS Scan Results:
Total issues: 43 |
|
License Evaluation Results:
Total License Issues: 0 |
shkumari-px
requested review from
kgarg-px,
siva-portworx,
pallav-px,
vsundarraj-px,
vikasit12 and
prashanthpx
dbinnal-px
reviewed
Aug 30, 2024
| @@ -64,7 +64,7 @@ vet: | |||
| go vet $(PKGS) | |||
|
|
|||
| staticcheck: | |||
| GOFLAGS="" go install honnef.co/go/tools/cmd/staticcheck@v0.4.7 | |||
| GOFLAGS="" go install honnef.co/go/tools/cmd/staticcheck@latest | |||
There was a problem hiding this comment.
any reason why we are changing this? Because as per I remember when it was 'latest' it was giving error while building docker image due to which we had given a specific version.
There was a problem hiding this comment.
+1 please confirm if we have to use latest or 0.4.7
There was a problem hiding this comment.
Go version 1.23 with staticcheck version 0.4.7 still gives error
dbinnal-px
reviewed
Aug 30, 2024
| @@ -2062,6 +2064,8 @@ message BackupCreateRequest { | |||
| map<string, string> volume_snapshot_class_mapping = 19; | |||
| // option to take backup as direct kdmp | |||
| bool direct_kdmp = 20; | |||
| // this flag will check if the backup is a synced backup | |||
| bool isSyncedBackup = 21; | |||
There was a problem hiding this comment.
I guess we don't need this in create request. As a synced backup is created through the backupsync
There was a problem hiding this comment.
+1 having the bool in BackupInfo is enough, Since backup sync objects are created through BackupSync function and not backupCreate function in px-backup. Having the variable in BackupInfo as a property of backup (BackupInfo message) should suffice here.
There was a problem hiding this comment.
@dbinnal-px @kgarg-px
When we sync the backup, we create a new backup object in the mongodb
so you need the flag in the createBackupRequest as well
|
@shkumari-px Let us add a flag called backup_variant ( generic backup type) and add enums to classify them as manual /schedule /synced backup. |
|
Closing this pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: it adds a flag isSyncedBackup to check if the backup is a synced backup
Which issue(s) this PR fixes (optional)
Closes # https://purestorage.atlassian.net/browse/PB-7615
Special notes for your reviewer: na