Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PB-7977 : Deprecating delete_backups while deleting BL or cluster #257

Merged
merged 1 commit into from
Sep 2, 2024
Merged

PB-7977 : Deprecating delete_backups while deleting BL or cluster #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Do not use directly, use `make docker-build-proto` instead
#

FROM golang:1.20
FROM golang:1.23
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope this won't conflict with px-backup golang version?

ENV GOPATH=/go
RUN mkdir -p portworx/px-backup-api
WORKDIR portworx/px-backup-api
Expand Down
5 changes: 4 additions & 1 deletion pkg/apis/v1/api.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pkg/apis/v1/api.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1295,6 +1295,7 @@ message ClusterDeleteRequest {
string name = 2;
// delete_backups indicates whether the backup related to cluster need to
// be deleted or retained.
// delete_backups is deprecated, not to be used.
bool delete_backups = 3;
// delete_restores indicates whether the restore related to cluster need to
// be deleted or retained.
Expand Down Expand Up @@ -1815,6 +1816,7 @@ message BackupLocationDeleteRequest {
string name = 2;
// delete_backups indicates whether the cloud backup files need to
// be deleted or retained.
// delete_backups is deprecated, not to be used.
bool delete_backups = 3;
string uid = 4;
}
Expand Down
7 changes: 4 additions & 3 deletions pkg/apis/v1/api.swagger.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,7 +538,7 @@
},
{
"name": "delete_backups",
"description": "delete_backups indicates whether the cloud backup files need to\nbe deleted or retained.",
"description": "delete_backups indicates whether the cloud backup files need to\nbe deleted or retained.\ndelete_backups is deprecated, not to be used.",
"in": "query",
"required": false,
"type": "boolean",
Expand Down Expand Up @@ -1166,7 +1166,7 @@
},
{
"name": "delete_backups",
"description": "delete_backups indicates whether the backup related to cluster need to\nbe deleted or retained.",
"description": "delete_backups indicates whether the backup related to cluster need to\nbe deleted or retained.\ndelete_backups is deprecated, not to be used.",
"in": "query",
"required": false,
"type": "boolean",
Expand Down Expand Up @@ -3295,7 +3295,8 @@
},
"retention_time": {
"type": "string",
"format": "date-time"
"format": "date-time",
"title": "this will store the timestamp, when the retention period of locked backup will be expired"
}
}
},
Expand Down
Loading