-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PB-7977 : Deprecating delete_backups while deleting BL or cluster #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- delete_backups deprecated from ClusterDeleteRequest - delete_backups deprecated from BackupLocationDeleteRequest Signed-off-by: Vikas Kumar <[email protected]>
OSS Scan Results:
Total issues: 43 |
License Evaluation Results:
Total License Issues: 0 |
vikasit12
requested review from
lalat-das,
prashanthpx,
siva-portworx,
t-nidhin,
px-kesavan,
sgajawada-px,
ss-px,
aks-px,
pallav-px,
vsundarraj-px,
dbinnal-px and
kgarg-px
August 30, 2024 11:12
dbinnal-px
approved these changes
Aug 30, 2024
ss-px
approved these changes
Aug 30, 2024
ss-px
approved these changes
Aug 30, 2024
px-kesavan
approved these changes
Aug 30, 2024
t-nidhin
reviewed
Aug 30, 2024
@@ -2,7 +2,7 @@ | |||
# Do not use directly, use `make docker-build-proto` instead | |||
# | |||
|
|||
FROM golang:1.20 | |||
FROM golang:1.23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hope this won't conflict with px-backup golang version?
t-nidhin
approved these changes
Aug 30, 2024
kgarg-px
approved these changes
Aug 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Removes the provision to delete the backups on deleting backup location or cluster by deprecating the bool parameter
Which issue(s) this PR fixes (optional)
Closes #PB-7977
Special notes for your reviewer: