Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PB-7977 : Deprecating delete_backups while deleting BL or cluster #257

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

vikasit12
Copy link
Collaborator

  • delete_backups deprecated from ClusterDeleteRequest
  • delete_backups deprecated from BackupLocationDeleteRequest

What this PR does / why we need it:
Removes the provision to delete the backups on deleting backup location or cluster by deprecating the bool parameter

Which issue(s) this PR fixes (optional)
Closes #PB-7977

Special notes for your reviewer:

- delete_backups deprecated from ClusterDeleteRequest
- delete_backups deprecated from BackupLocationDeleteRequest

Signed-off-by: Vikas Kumar <[email protected]>
Copy link

OSS Scan Results:

Title Severity Package Name CVEs Fix version Introduced
Denial of Service (DoS) high golang.org/x/net/http2 ['CVE-2023-44487'] ['0.17.0'] ['github.com/portworx/[email protected]', 'k8s.io/client-go/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling medium golang.org/x/net/http2 ['CVE-2023-39325'] ['0.17.0'] ['github.com/portworx/[email protected]', 'k8s.io/client-go/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling high golang.org/x/net/http2 ['CVE-2023-45288'] ['0.23.0'] ['github.com/portworx/[email protected]', 'k8s.io/client-go/[email protected]', 'golang.org/x/net/[email protected]']
Denial of Service (DoS) high golang.org/x/net/http2 ['CVE-2023-44487'] ['0.17.0'] ['github.com/portworx/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling medium golang.org/x/net/http2 ['CVE-2023-39325'] ['0.17.0'] ['github.com/portworx/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling high golang.org/x/net/http2 ['CVE-2023-45288'] ['0.23.0'] ['github.com/portworx/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'golang.org/x/net/[email protected]']
Denial of Service (DoS) high golang.org/x/net/http2 ['CVE-2023-44487'] ['0.17.0'] ['github.com/portworx/[email protected]', 'k8s.io/client-go/tools/[email protected]', 'k8s.io/client-go/tools/[email protected]', 'k8s.io/client-go/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling medium golang.org/x/net/http2 ['CVE-2023-39325'] ['0.17.0'] ['github.com/portworx/[email protected]', 'k8s.io/client-go/tools/[email protected]', 'k8s.io/client-go/tools/[email protected]', 'k8s.io/client-go/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling high golang.org/x/net/http2 ['CVE-2023-45288'] ['0.23.0'] ['github.com/portworx/[email protected]', 'k8s.io/client-go/tools/[email protected]', 'k8s.io/client-go/tools/[email protected]', 'k8s.io/client-go/[email protected]', 'golang.org/x/net/[email protected]']
Denial of Service (DoS) high golang.org/x/net/http2 ['CVE-2023-44487'] ['0.17.0'] ['github.com/portworx/[email protected]', 'k8s.io/client-go/[email protected]', 'k8s.io/client-go/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling medium golang.org/x/net/http2 ['CVE-2023-39325'] ['0.17.0'] ['github.com/portworx/[email protected]', 'k8s.io/client-go/[email protected]', 'k8s.io/client-go/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling high golang.org/x/net/http2 ['CVE-2023-45288'] ['0.23.0'] ['github.com/portworx/[email protected]', 'k8s.io/client-go/[email protected]', 'k8s.io/client-go/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Denial of Service (DoS) high golang.org/x/net/http2 ['CVE-2023-44487'] ['0.17.0'] ['github.com/portworx/[email protected]', 'k8s.io/cli-runtime/pkg/[email protected]', 'k8s.io/apimachinery/pkg/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling medium golang.org/x/net/http2 ['CVE-2023-39325'] ['0.17.0'] ['github.com/portworx/[email protected]', 'k8s.io/cli-runtime/pkg/[email protected]', 'k8s.io/apimachinery/pkg/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling high golang.org/x/net/http2 ['CVE-2023-45288'] ['0.23.0'] ['github.com/portworx/[email protected]', 'k8s.io/cli-runtime/pkg/[email protected]', 'k8s.io/apimachinery/pkg/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Denial of Service (DoS) high golang.org/x/net/http2 ['CVE-2023-44487'] ['0.17.0'] ['github.com/portworx/[email protected]', 'github.com/portworx/sched-ops/k8s/core@#2e0ef25efadd', 'k8s.io/client-go/tools/[email protected]', 'k8s.io/client-go/transport/[email protected]', 'k8s.io/client-go/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling medium golang.org/x/net/http2 ['CVE-2023-39325'] ['0.17.0'] ['github.com/portworx/[email protected]', 'github.com/portworx/sched-ops/k8s/core@#2e0ef25efadd', 'k8s.io/client-go/tools/[email protected]', 'k8s.io/client-go/transport/[email protected]', 'k8s.io/client-go/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling high golang.org/x/net/http2 ['CVE-2023-45288'] ['0.23.0'] ['github.com/portworx/[email protected]', 'github.com/portworx/sched-ops/k8s/core@#2e0ef25efadd', 'k8s.io/client-go/tools/[email protected]', 'k8s.io/client-go/transport/[email protected]', 'k8s.io/client-go/[email protected]', 'golang.org/x/net/[email protected]']
Denial of Service (DoS) high golang.org/x/net/http2 ['CVE-2023-44487'] ['0.17.0'] ['github.com/portworx/[email protected]', 'github.com/portworx/sched-ops/k8s/core@#2e0ef25efadd', 'k8s.io/client-go/tools/[email protected]', 'k8s.io/client-go/transport/[email protected]', 'k8s.io/client-go/[email protected]', 'k8s.io/client-go/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling medium golang.org/x/net/http2 ['CVE-2023-39325'] ['0.17.0'] ['github.com/portworx/[email protected]', 'github.com/portworx/sched-ops/k8s/core@#2e0ef25efadd', 'k8s.io/client-go/tools/[email protected]', 'k8s.io/client-go/transport/[email protected]', 'k8s.io/client-go/[email protected]', 'k8s.io/client-go/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling high golang.org/x/net/http2 ['CVE-2023-45288'] ['0.23.0'] ['github.com/portworx/[email protected]', 'github.com/portworx/sched-ops/k8s/core@#2e0ef25efadd', 'k8s.io/client-go/tools/[email protected]', 'k8s.io/client-go/transport/[email protected]', 'k8s.io/client-go/[email protected]', 'k8s.io/client-go/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Denial of Service (DoS) high golang.org/x/net/http2 ['CVE-2023-44487'] ['0.17.0'] ['github.com/portworx/[email protected]', 'k8s.io/client-go/tools/clientcmd/api/[email protected]', 'k8s.io/apimachinery/pkg/runtime/serializer/[email protected]', 'k8s.io/apimachinery/pkg/apis/meta/v1/[email protected]', 'k8s.io/apimachinery/pkg/apis/meta/[email protected]', 'k8s.io/apimachinery/pkg/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling medium golang.org/x/net/http2 ['CVE-2023-39325'] ['0.17.0'] ['github.com/portworx/[email protected]', 'k8s.io/client-go/tools/clientcmd/api/[email protected]', 'k8s.io/apimachinery/pkg/runtime/serializer/[email protected]', 'k8s.io/apimachinery/pkg/apis/meta/v1/[email protected]', 'k8s.io/apimachinery/pkg/apis/meta/[email protected]', 'k8s.io/apimachinery/pkg/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling high golang.org/x/net/http2 ['CVE-2023-45288'] ['0.23.0'] ['github.com/portworx/[email protected]', 'k8s.io/client-go/tools/clientcmd/api/[email protected]', 'k8s.io/apimachinery/pkg/runtime/serializer/[email protected]', 'k8s.io/apimachinery/pkg/apis/meta/v1/[email protected]', 'k8s.io/apimachinery/pkg/apis/meta/[email protected]', 'k8s.io/apimachinery/pkg/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Denial of Service (DoS) high golang.org/x/net/http2 ['CVE-2023-44487'] ['0.17.0'] ['github.com/portworx/[email protected]', 'sigs.k8s.io/aws-iam-authenticator/pkg/[email protected]', 'k8s.io/client-go/pkg/apis/clientauthentication/[email protected]', 'k8s.io/client-go/pkg/apis/[email protected]', 'k8s.io/apimachinery/pkg/apis/meta/[email protected]', 'k8s.io/apimachinery/pkg/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling medium golang.org/x/net/http2 ['CVE-2023-39325'] ['0.17.0'] ['github.com/portworx/[email protected]', 'sigs.k8s.io/aws-iam-authenticator/pkg/[email protected]', 'k8s.io/client-go/pkg/apis/clientauthentication/[email protected]', 'k8s.io/client-go/pkg/apis/[email protected]', 'k8s.io/apimachinery/pkg/apis/meta/[email protected]', 'k8s.io/apimachinery/pkg/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling high golang.org/x/net/http2 ['CVE-2023-45288'] ['0.23.0'] ['github.com/portworx/[email protected]', 'sigs.k8s.io/aws-iam-authenticator/pkg/[email protected]', 'k8s.io/client-go/pkg/apis/clientauthentication/[email protected]', 'k8s.io/client-go/pkg/apis/[email protected]', 'k8s.io/apimachinery/pkg/apis/meta/[email protected]', 'k8s.io/apimachinery/pkg/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Denial of Service (DoS) high golang.org/x/net/http2 ['CVE-2023-44487'] ['0.17.0'] ['github.com/portworx/[email protected]', 'k8s.io/client-go/tools/[email protected]', 'k8s.io/client-go/tools/clientcmd/api/[email protected]', 'k8s.io/apimachinery/pkg/runtime/serializer/[email protected]', 'k8s.io/apimachinery/pkg/apis/meta/v1/[email protected]', 'k8s.io/apimachinery/pkg/apis/meta/[email protected]', 'k8s.io/apimachinery/pkg/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling medium golang.org/x/net/http2 ['CVE-2023-39325'] ['0.17.0'] ['github.com/portworx/[email protected]', 'k8s.io/client-go/tools/[email protected]', 'k8s.io/client-go/tools/clientcmd/api/[email protected]', 'k8s.io/apimachinery/pkg/runtime/serializer/[email protected]', 'k8s.io/apimachinery/pkg/apis/meta/v1/[email protected]', 'k8s.io/apimachinery/pkg/apis/meta/[email protected]', 'k8s.io/apimachinery/pkg/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Allocation of Resources Without Limits or Throttling high golang.org/x/net/http2 ['CVE-2023-45288'] ['0.23.0'] ['github.com/portworx/[email protected]', 'k8s.io/client-go/tools/[email protected]', 'k8s.io/client-go/tools/clientcmd/api/[email protected]', 'k8s.io/apimachinery/pkg/runtime/serializer/[email protected]', 'k8s.io/apimachinery/pkg/apis/meta/v1/[email protected]', 'k8s.io/apimachinery/pkg/apis/meta/[email protected]', 'k8s.io/apimachinery/pkg/[email protected]', 'k8s.io/apimachinery/pkg/util/[email protected]', 'golang.org/x/net/[email protected]']
Denial of Service (DoS) high google.golang.org/grpc ['CVE-2023-44487'] ['1.56.3', '1.57.1', '1.58.3'] ['github.com/portworx/[email protected]', 'google.golang.org/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/grpc-ecosystem/grpc-gateway/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Infinite loop medium google.golang.org/protobuf/encoding/protojson ['CVE-2024-24786'] ['1.33.0'] ['github.com/portworx/[email protected]', 'github.com/grpc-ecosystem/grpc-gateway/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/[email protected]', 'google.golang.org/protobuf/types/known/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Infinite loop medium google.golang.org/protobuf/encoding/protojson ['CVE-2024-24786'] ['1.33.0'] ['github.com/portworx/[email protected]', 'github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/[email protected]', 'google.golang.org/protobuf/types/known/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Infinite loop medium google.golang.org/protobuf/encoding/protojson ['CVE-2024-24786'] ['1.33.0'] ['github.com/portworx/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Stack-based Buffer Overflow medium google.golang.org/protobuf/encoding/protojson [] ['1.32.0'] ['github.com/portworx/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Infinite loop medium google.golang.org/protobuf/encoding/protojson ['CVE-2024-24786'] ['1.33.0'] ['github.com/portworx/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]']
Infinite loop medium google.golang.org/protobuf/internal/encoding/json ['CVE-2024-24786'] ['1.33.0'] ['github.com/portworx/[email protected]', 'github.com/grpc-ecosystem/grpc-gateway/[email protected]', 'github.com/golang/protobuf/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]', 'google.golang.org/protobuf/internal/encoding/[email protected]']
Infinite loop medium google.golang.org/protobuf/internal/encoding/json ['CVE-2024-24786'] ['1.33.0'] ['github.com/portworx/[email protected]', 'github.com/grpc-ecosystem/grpc-gateway/v2/protoc-gen-openapiv2/[email protected]', 'google.golang.org/protobuf/types/known/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]', 'google.golang.org/protobuf/internal/encoding/[email protected]']
Infinite loop medium google.golang.org/protobuf/internal/encoding/json ['CVE-2024-24786'] ['1.33.0'] ['github.com/portworx/[email protected]', 'google.golang.org/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/grpc/internal/[email protected]', 'google.golang.org/protobuf/encoding/[email protected]', 'google.golang.org/protobuf/internal/encoding/[email protected]']
Improper Input Validation high sigs.k8s.io/aws-iam-authenticator/pkg/token ['CVE-2022-2385'] ['0.5.9'] ['github.com/portworx/[email protected]', 'sigs.k8s.io/aws-iam-authenticator/pkg/[email protected]']

Total issues: 43

Copy link

License Evaluation Results:

Title Package Name Package Version Severity License Info Introduced Dependency Type

Total License Issues: 0

@@ -2,7 +2,7 @@
# Do not use directly, use `make docker-build-proto` instead
#

FROM golang:1.20
FROM golang:1.23
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hope this won't conflict with px-backup golang version?

Copy link
Collaborator

@kgarg-px kgarg-px left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vikasit12 vikasit12 merged commit 839ae74 into master Sep 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants