-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (invalid) test cases of proportions == 0.0 #167
Conversation
Thanks for getting this rolling... I have a couple of additional test cases (for the defaults section), and the corresponding fixes for the reference implementation. I just ran out of time to commit and pull request yesterday. I can just add them on top of your PR, if you don't mind? |
@grahamgower -- go for it! |
f219a21
to
1241a8d
Compare
@grahamgower -- I just rebased this onto main so that CI works. |
This also uses the terms 'proportion' and 'rate' to match the json schema, rather than using the term 'fraction'.
@molpopgen, could you please run your eye over the changes I added here? If you're ok with it, I think it can be merged. |
LGTM but not sure why some changes concern selfing/cloning rates? |
In the schema definitions, we have (a) |
Seems like this one is ready to go! |
See #166.
See also popsim-consortium/demes-python#576