Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update requirements.txt and some CI config #168

Merged
merged 1 commit into from
Nov 18, 2024
Merged

Conversation

molpopgen
Copy link
Contributor

  • Update Ubuntu CI image
  • Bump Python in CI to something not EOL
  • rebuild requirements.txt using uv

@molpopgen
Copy link
Contributor Author

@grahamgower

This has to happen before anything else can work (#167, etc.).

One proposal/question for this one:

I'd argue that we can take the requirements_old.txt and:

  • rename it requirements.txt
  • remove all the version pins
  • rename the requirements.txt in this PR to requirements_locked.txt or requirements_CI.txt

A change like this would reproducible builds in CI, allow things like uv to regenerate the locked file for us, etc..

@grahamgower
Copy link
Member

I like your suggested changes, @molpopgen! If using uv makes it easier to deal with the inevitable (and rapid) project bitrot, then I'm all for it!

@molpopgen
Copy link
Contributor Author

I like your suggested changes, @molpopgen! If using uv makes it easier to deal with the inevitable (and rapid) project bitrot, then I'm all for it!

Sounds good -- I'll move those files around and update CI work flows accordingly. uv is surprisingly good! And even if Python keeps being Python and something else replaces it, it is still nice to not have to build these lock files by hand.

@molpopgen
Copy link
Contributor Author

@grahamgower -- I made those changes and squashed it all down.

@grahamgower grahamgower merged commit 89a054a into main Nov 18, 2024
4 checks passed
@molpopgen molpopgen deleted the update_requirements branch November 18, 2024 21:45
@grahamgower
Copy link
Member

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants