Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add context errors as allowed direct comparisons #63

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Add context errors as allowed direct comparisons #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions errorlint/allowed.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ var allowedErrors = []struct {
{err: "io.EOF", fun: "(*strings.Reader).ReadAt"},
{err: "io.EOF", fun: "(*strings.Reader).ReadByte"},
{err: "io.EOF", fun: "(*strings.Reader).ReadRune"},
// pkg/context
{err: "context.DeadlineExceeded", fun: "(context.Context).Err"},
{err: "context.Canceled", fun: "(context.Context).Err"},
}

var allowedErrorWildcards = []struct {
Expand Down
11 changes: 11 additions & 0 deletions errorlint/testdata/src/allowed/allowed.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package testdata
import (
"archive/tar"
"bytes"
"context"
"database/sql"
"debug/elf"
"errors"
Expand Down Expand Up @@ -227,3 +228,13 @@ func CompareUnixErrors() {
fmt.Println(err)
}
}

func ContextErr(ctx context.Context) error {
if err := ctx.Err(); err == context.DeadlineExceeded {
return err
}
if err := ctx.Err(); err == context.Canceled {
return err
}
return nil
}
Loading