Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create table and related cache for additional instance data #1262

Open
wants to merge 25 commits into
base: main
Choose a base branch
from

Merge branch 'main' into new_table_for_instance_console

92c12ed
Select commit
Loading
Failed to load commit list.
Open

Create table and related cache for additional instance data #1262

Merge branch 'main' into new_table_for_instance_console
92c12ed
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 29, 2024 in 0s

50.59% (-0.08%) compared to 7aace3c

View this Pull Request on Codecov

50.59% (-0.08%) compared to 7aace3c

Details

Codecov Report

Attention: Patch coverage is 24.13793% with 66 lines in your changes missing coverage. Please review.

Project coverage is 50.59%. Comparing base (7aace3c) to head (92c12ed).

Files with missing lines Patch % Lines
store/mysql/instance.go 15.87% 49 Missing and 4 partials ⚠️
cache/service/instance.go 56.25% 4 Missing and 3 partials ⚠️
store/boltdb/instance.go 25.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
- Coverage   50.66%   50.59%   -0.08%     
==========================================
  Files         218      218              
  Lines       34210    34297      +87     
==========================================
+ Hits        17333    17353      +20     
- Misses      14596    14652      +56     
- Partials     2281     2292      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.