Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create table and related cache for additional instance data #1262

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Create table and related cache for additional instance data #1262

wants to merge 25 commits into from

Conversation

fabian4
Copy link
Contributor

@fabian4 fabian4 commented Sep 26, 2023 •
edited
Loading

Please provide issue(s) of this PR:
Fixes #1257

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • ApiServer
  • Auth
  • Configuration
  • Naming
  • HealthCheck
  • Metrics
  • Docs
  • Installation
  • Performance and Scalability
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@fabian4 fabian4 mentioned this pull request Sep 26, 2023
Open
5 tasks
@fabian4 fabian4 marked this pull request as ready for review October 10, 2023 15:29
@fabian4 fabian4 closed this Oct 13, 2023
@fabian4 fabian4 reopened this Oct 13, 2023
daheige
daheige approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@daheige daheige left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional instance data LGTM

@daheige
Copy link
Member

daheige commented Aug 12, 2024

This design looks good. Please solve the problem of related files. Thank you very much.

@daheige
Copy link
Member

daheige commented Sep 10, 2024

please solve these Conflicting files:
auth/defaultauth/common_test.go
cache/service/instance.go
go.mod
go.sum
store/mock/api_mock.go

@fabian4
Merge branch 'refs/heads/main' into new_table_for_instance_console
c765ac6 
# Conflicts:
#	cache/service/instance.go
#	go.mod
#	go.sum
#	store/mock/api_mock.go
@fabian4
feat: add related cache for additional instance data.
5e19f35
@fabian4
Merge branch 'main' into new_table_for_instance_console
d3ce712 
# Conflicts:
#	auth/user/common_test.go
#	store/mysql/scripts/delta/v1_18_1-v1_19_0.sql
@codecov Codecov
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 24.13793% with 66 lines in your changes missing coverage. Please review.

Project coverage is 50.59%. Comparing base (7aace3c) to head (92c12ed).

Files with missing lines Patch % Lines
store/mysql/instance.go 15.87% 49 Missing and 4 partials ⚠️
cache/service/instance.go 56.25% 4 Missing and 3 partials ⚠️
store/boltdb/instance.go 25.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1262      +/-   ##
==========================================
- Coverage   50.66%   50.59%   -0.08%     
==========================================
  Files         218      218              
  Lines       34210    34297      +87     
==========================================
+ Hits        17333    17353      +20     
- Misses      14596    14652      +56     
- Partials     2281     2292      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daheige daheige daheige approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add storage for additional information about instance added by user on console.
2 participants
@fabian4 @daheige