Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1015

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Update dependencies #1015

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
837965d
Update Ruby dependencies
sul-devops-team Dec 4, 2023
01b43b1
Add rubocop:disable Style/HashEachMethods comment
corylown Dec 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/jobs/marc_profiling_job.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,11 @@ def add(item)
@sample[j] = [@size_so_far, item] if @wanted > j
end

# rubocop:disable Style/HashEachMethods
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we disabling this rather than fixing it?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests suggest that each is operating on an Array and each_value isn't defined for Array:

Failure/Error: @sample.sort.each_value { |it| yield(it) }
     
     NoMethodError:
       undefined method `each_value' for [[2, ["a500001", "a500001"]], [4, ["a500003", "a500003"]],...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I will create a bug report for rubocop then.

def each
@sample.sort.each { |_idx, it| yield(it) }
end
# rubocop:enable Style/HashEachMethods
end

# Tally up some statistics about the MARC records in the file:
Expand Down