Update dependencies #1015
Merged
Update dependencies #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corylown
force-pushed
the
update-dependencies
branch
from
228138b to
01b43b1
Compare
jcoyne
reviewed
Dec 4, 2023
| @@ -22,9 +22,11 @@ def add(item) | |||
| @sample[j] = [@size_so_far, item] if @wanted > j | |||
| end | |||
|
|
|||
| # rubocop:disable Style/HashEachMethods | |||
There was a problem hiding this comment.
Why are we disabling this rather than fixing it?
There was a problem hiding this comment.
The tests suggest that each is operating on an Array and each_value isn't defined for Array:
Failure/Error: @sample.sort.each_value { |it| yield(it) }
NoMethodError:
undefined method `each_value' for [[2, ["a500001", "a500001"]], [4, ["a500003", "a500003"]],...
There was a problem hiding this comment.
Thank you. I will create a bug report for rubocop then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.