Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add function to demo nb to convert CSV output file to JSON #67

Merged
merged 3 commits into from
Nov 20, 2023

Conversation

jaelynlitz
Copy link
Contributor

Merge request type

  • New feature
  • Resolves bug
  • Documentation
  • Other

Relates to

  • OPFLOW
  • SOPFLOW
  • SCOPFLOW
  • TCOPFLOW
  • CMake build system
  • Spack configuration
  • Manual
  • Web docs
  • Other (Python demo)

This MR updates

  • Header files
  • Source code
  • CMake build system
  • Spack configuration
  • Web docs
  • Manual
  • Other (Python demo)

Summary

In the tutorial notebook, convert an opflow output CSV file to a JSON dictionary

Linked Issue(s)
Partially addresses #35

@jaelynlitz jaelynlitz self-assigned this Nov 8, 2023
@cameronrutherford
Copy link
Contributor

This is the first iteration of support. More important feature is Python api of getSolution that will return the solution in-place.

We should also make sure this approach and the API getSolution return the same data type/structure somehow...

@jaelynlitz
Copy link
Contributor Author

This is the first iteration of support. More important feature is Python api of getSolution that will return the solution in-place.

We should also make sure this approach and the API getSolution return the same data type/structure somehow...

Right, this is bullet 2 in #35 - with the goal to get things working for Shri by Monday. There are some things rn that I imagine are hard-coded to the OPFLOW output that I'm not sure how they'll differ for SCOPFLOW for example.

@jaelynlitz jaelynlitz force-pushed the jupyter-save-solution branch from 23e77d6 to 3420238 Compare November 11, 2023 00:06
@jaelynlitz
Copy link
Contributor Author

rebuilding the container to double check that everything still works then ready to merge if you agree @abhyshr

@abhyshr
Copy link
Collaborator

abhyshr commented Nov 16, 2023

Can you please put the CSV->JSON conversion code in a separate file? Also, one can directly load the JSON output file created by OPFLOW using the JSON module in python. That's another alternative for users.

@abhyshr
Copy link
Collaborator

abhyshr commented Nov 16, 2023

Good to merge when the seperate source file is created.

@cameronrutherford
Copy link
Contributor

Good to merge when the seperate source file is created.

@abhyshr I think we should merge this, and then in another PR create a separate notebook talking about I/O, and use this as the starting point.

Would be good to also do a small benchmark of the different approaches in this new notebook, and provide suggestions to users. That way we can also encourage future ExaGO users to contribute different/better examples as the project evolves.

@cameronrutherford cameronrutherford merged commit beb27a7 into develop Nov 20, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants