-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add function to demo nb to convert CSV output file to JSON #67
Conversation
This is the first iteration of support. More important feature is Python api of We should also make sure this approach and the API |
Right, this is bullet 2 in #35 - with the goal to get things working for Shri by Monday. There are some things rn that I imagine are hard-coded to the OPFLOW output that I'm not sure how they'll differ for SCOPFLOW for example. |
23e77d6
to
3420238
Compare
rebuilding the container to double check that everything still works then ready to merge if you agree @abhyshr |
Can you please put the CSV->JSON conversion code in a separate file? Also, one can directly load the JSON output file created by OPFLOW using the JSON module in python. That's another alternative for users. |
Good to merge when the seperate source file is created. |
@abhyshr I think we should merge this, and then in another PR create a separate notebook talking about I/O, and use this as the starting point. Would be good to also do a small benchmark of the different approaches in this new notebook, and provide suggestions to users. That way we can also encourage future ExaGO users to contribute different/better examples as the project evolves. |
Merge request type
Relates to
This MR updates
Summary
In the tutorial notebook, convert an opflow output CSV file to a JSON dictionary
Linked Issue(s)
Partially addresses #35