-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mpi4py Jupyter tutorial and frontend tutorial outline #69
Conversation
6feab41
to
835651a
Compare
viz/package.json
Outdated
"@emotion/react": "^11.9.0", | ||
"@emotion/styled": "^11.8.1", | ||
"@flowmap.gl/data": "^8.0.0-alpha.25", | ||
"@flowmap.gl/layers": "^8.0.0-alpha.25", | ||
"@mui/icons-material": "^5.6.2", | ||
"@mui/material": "^5.6.4", | ||
"@turf/turf": "^5.1.6", | ||
"babel-preset-env": "^1.7.0", | ||
"babel-preset-es2015": "^6.24.1", | ||
"bootstrap": "^5.3.0", | ||
"buffer": "^6.0.3", | ||
"chart.js": "^3.5.0", | ||
"core-js": "^3.31.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I am really hacking away here (unsuccessfully), so some guidance from Sichen would be awesome here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does setting the version numbers of the packages to null work on your system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to try adding back in these versions and pinning Node version. Should get a build going I hope, but I still have some open questions about preparing data for viz...
@abhyshr please review the notebook. I have 0 clue how to prepare data for the viz, but the frontend is trying to launch and erroring when looking for data. |
"source": [ | ||
"# Appendix\n", | ||
"\n", | ||
"From https://github.com/mpi4py/mpi4py/issues/15#issuecomment-765658147, had to modify mpi4py init routines by hand - this was all due to a red-herring, but is interesting discussion." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you leave this change in place or was it irrelevant?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to merge.
I will make a few clean up/clarifying changes, then can merge as I believe @cameronrutherford is out for the day/will be out next week |
Don't fret on optimizing this too much. Just merge when it's ready (making sure nothing is crashing) I will most likely be making changes that suit my needs for the workshop. So, these notebooks will be updated later on. |
Sounds good, just adding some notes from my code review - will merge once the pipelines finish 😄 Then I'll rebase my branch #67 |
I accidentally merged all of the commits individually into develop instead of a squash and merge. I have now disabled the "bug" options, and now no longer allow merge commits or rebase and merge. Squash and merge is the only option. |
Merge request type
Relates to
This MR updates
Summary
Partially closes #49.
cc @abhyshr please review this for your workshop. Please also see if Sichen can review the notebook that I have attended and if we can debug the remaining frontend errors. While it would be nice to containerize it, I think we can merge this as is and debug later. If you can run locally outside of devcontainer that works too.