-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: witnesscalc build #91
Conversation
Co-authored-by: devloper <[email protected]> Co-authored-by: Sambhav Dusad <[email protected]> Co-authored-by: Colin Roberts <[email protected]> Signed-off-by: Waylon Jepsen <[email protected]>
Now the issues seem to only be in GCTR and KeyExpansion
YOU CANNOT HAVE A LOOP THAT EVER HAS A 0 SIZE OR ELSE THIS THING POOPS
@0xJepsen @thor314 I will need your help to get this to pass tests and what not. Also the constraints for |
b989ac2
to
1d08e13
Compare
All tests are passing, but I would appreciate reviewers giving this another look to make sure that this is still totally working as expected. |
Potential improvement noted here
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed this when I updated the tests and confirmed that the changes are working as expected. From my PoV this is ready to go, the primary blocker atm is that it's dependent on the PP PR (the circuit interface changes)
We can probably merge this now, given that upstream repos should be pinned to a specific version of aes-proof.
If helpful, my espanso todo replacement snippets: # espanso replace snippet
- triggers: ["TODO ", "tdd "]
replace: "TODO(TK {{date}}): "
vars:
- name: date
type: date
params:
format: "%Y-%m-%d"
- triggers: ["tdb "]
replace: "- [ ] TODO(TK {{date}}): "
vars:
- name: date
type: date
params:
format: "%Y-%m-%d"
- triggers: ["tdc "]
replace: "// TODO(TK {{date}}): "
vars:
- name: date
type: date
params:
format: "%Y-%m-%d"
- triggers: ["tdp "]
replace: "TODO(TK): "
|
@Autoparallel, this looks good to go after the comments I made above |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work on this
@devloper @Autoparallel Would you annotate your todos:
e.g. a bare TODO is nice for working alone, but it doesn't say much about how old the thing is for the reader; makes me git blame to see all the relevant metadata |
To verify this is all working, you can run:
to generate the graph file for witness extension.
To see the constraint count for
aes-gcm-fold
, you can run:Currently addresses:
Need to solve:
aes-gcm-fold
with respect tocircom-witnesscalc
#93Which the following may help with: