-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide an IContentListingObject adapter #411
base: master
Are you sure you want to change the base?
Conversation
@erral thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
e64b245
to
7426601
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@erral Could you take a look at the failing tests, and add a new test which shows getting some values from the occurrence adapter?
@jenkins-plone-org please run jobs |
if hasattr(obj, name): | ||
return getattr(obj, name) | ||
raise AttributeError(name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure this can be simplified to
if hasattr(obj, name): | |
return getattr(obj, name) | |
raise AttributeError(name) | |
return getattr(obj, name) |
There's no need to check for the attribute before getting it. getattr will already raise AttributeError if it's not there.
No description provided.