Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provide an IContentListingObject adapter #411

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

erral
Copy link
Member

@erral erral commented Sep 12, 2024

No description provided.

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erral Could you take a look at the failing tests, and add a new test which shows getting some values from the occurrence adapter?

@erral
Copy link
Member Author

erral commented Oct 10, 2024

@jenkins-plone-org please run jobs

Comment on lines +20 to +22
if hasattr(obj, name):
return getattr(obj, name)
raise AttributeError(name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this can be simplified to

Suggested change
if hasattr(obj, name):
return getattr(obj, name)
raise AttributeError(name)
return getattr(obj, name)

There's no need to check for the attribute before getting it. getattr will already raise AttributeError if it's not there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants