Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test event Occurrence serialization #1811

Merged
merged 15 commits into from
Oct 20, 2024

Conversation

erral
Copy link
Member

@erral erral commented Sep 12, 2024

Fixes #1809 testing that Occurrence serialization is correct.

To be tested with plone/plone.app.event#411


📚 Documentation preview 📚: https://plonerestapi--1811.org.readthedocs.build/

@mister-roboto
Copy link

@erral thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@erral erral changed the base branch from main to erral-issue-1809-main September 12, 2024 13:41
@erral erral changed the base branch from erral-issue-1809-main to main October 10, 2024 15:06
@erral erral changed the title Erral issue 1809 main with fixed plone app event Add Occurrence serialization and tests Oct 10, 2024
@erral erral changed the title Add Occurrence serialization and tests Test event Occurrence serialization Oct 10, 2024
@erral
Copy link
Member Author

erral commented Oct 10, 2024

@jenkins-plone-org please run jobs

news/1809.feature Outdated Show resolved Hide resolved
@davisagli davisagli merged commit 344dd9c into main Oct 20, 2024
21 of 25 checks passed
@davisagli davisagli deleted the erral-issue-1809-main-with-fixed-plone-app-event branch October 20, 2024 23:45
davisagli added a commit that referenced this pull request Oct 21, 2024
@davisagli
Copy link
Member

Reverted because the tests were broken on the main branch: https://github.com/plone/plone.restapi/actions/runs/11430621159

I don't understand why they were passing on this PR but failed after merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when serializing a Collection that includes Events with recurrences
3 participants