Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'vreplication_tablet_type' flag to run unmanaged vttablet v20 #576

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

yoheimuta
Copy link
Contributor

Description

This PR removes a flag called vreplication_tablet_type that is deleted on Vitess v20.
See https://github.com/vitessio/vitess/blob/main/changelog/20.0/20.0.0/release_notes.md#vreplication-tablet-type-deletion.

Related Issue(s)

fixes: #575

Copy link
Collaborator

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you! We should backport this to release-2.13 so it will be included in the next v2.13 release.

@frouioui frouioui merged commit afaa378 into planetscale:main Jul 18, 2024
10 checks passed
frouioui added a commit that referenced this pull request Jul 18, 2024
Remove 'vreplication_tablet_type' flag to run unmanaged vttablet v20

Signed-off-by: Florent Poinsard <[email protected]>
@yoheimuta
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug Report: Unable to run unmanged vttablet v20 due to "Error: unknown flag: --vreplication_tablet_type"
3 participants