Add unmanaged_tablet_test.sh to run a new e2e build on CI #578
Conversation
… the future Vitess operator Signed-off-by: Yohei Yoshimuta <[email protected]>
| @@ -107,7 +107,7 @@ from the pull request, so in order to have the tag on the release branche's hist | |||
|
|
|||
| ##### Update the test output | |||
|
|
|||
| The `upgrade_test.sh`, `backup_restore_test.sh` and `vtorc_vtadmin_test.sh` files must be updated with the proper release increment. Change the `verifyVtGateVersion` function calls to use the proper version (current version being released and latest previous version (only used in `upgrade_test.sh`)). | |||
| The `upgrade_test.sh`, `backup_restore_test.sh`, `vtorc_vtadmin_test.sh` and `unmanaged_tablet_test.sh` files must be updated with the proper release increment. Change the `verifyVtGateVersion` function calls to use the proper version (current version being released and latest previous version (only used in `upgrade_test.sh`)). | |||
There was a problem hiding this comment.
note to self, we will also need to update the vitess-releaser with the new file
| assertSelect ../common/select_commerce_data.sql "commerce" << EOF | ||
| Using commerce | ||
| Customer | ||
| +-------------+--------------------+ | ||
| | customer_id | email | |
There was a problem hiding this comment.
Not necessarily in this Pull Request, but ideally we should extract some of the reused code into sharded shell functions. For instance all the code between line 28 and line 82 is mostly the same as in the four other tests. The function get_started() (in utils.sh) already extract all this code, but makes assumptions that are not always valid for every test, like the fact that vtorc is always here and that we expect a fixed number of vttablets.
|
It seems the test is failing because the branch does not contain the bug fix. I will merge |
Signed-off-by: Florent Poinsard <[email protected]>
frouioui
force-pushed
the
add-unmanaged-tablet-e2e
branch
from
2bed3a5 to
c1bf796
Compare
|
I have marked the new workflow as required in the branch protection rules. |
|
Thanks! |
Description
This PR adds a new e2e test to ensure unmanaged tablet runs on the latest operator.
You see the following output on my personal build space:
Related Issue(s)
fixes: #577