Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix keyword indexing: use publication id instead of submission id #10

Open
wants to merge 2 commits into
base: stable-3_3_0
Choose a base branch
from
Open

Fix keyword indexing: use publication id instead of submission id #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0908f41
Fix keyword indexing: use publication id instead of submission id
mpbraendle Mar 14, 2024
c12f2c0
Little tool to fetch a doc from Lucene/Solr Index
mpbraendle Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions classes/SolrWebService.inc.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ function pushChangedArticles($batchSize = SOLR_INDEXING_MAX_BATCHSIZE, $journalI
*/
function _indexingTransaction($sendXmlCallback, $batchSize = SOLR_INDEXING_MAX_BATCHSIZE, $journalId = null) {
$journalSettingsDao = DAORegistry::getDAO('JournalSettingsDAO');

$submissionArray = [];
$submissionsIterator = Services::get('submission')->getMany(['contextId' => $journalId , 'status' => STATUS_PUBLISHED]);
$submissionDao = DAORegistry::getDAO('SubmissionDAO');
Expand Down Expand Up @@ -465,7 +464,7 @@ function _addArticleXml($articleDoc, $article, $journal, $markToDelete = false)

// Add disciplines.
$submissionDisciplineDao = DAORegistry::getDAO('SubmissionDisciplineDAO');
$disciplines = $submissionDisciplineDao->getDisciplines($article->getId(), $supportedLocales);
$disciplines = $submissionDisciplineDao->getDisciplines($article->getData('currentPublicationId'), $supportedLocales);

foreach ($disciplines as $locale => $discipline) {
if (empty($discipline)) {
Expand All @@ -491,7 +490,7 @@ function _addArticleXml($articleDoc, $article, $journal, $markToDelete = false)
}

$submissionSubjectDao = DAORegistry::getDAO('SubmissionSubjectDAO');
$subjects = $submissionSubjectDao->getSubjects($article->getId(), $supportedLocales);
$subjects = $submissionSubjectDao->getSubjects($article->getData('currentPublicationId'), $supportedLocales);
foreach ($subjects as $locale => $subject) {
if (empty($subject)) {
unset($subjects[$locale]);
Expand All @@ -501,7 +500,7 @@ function _addArticleXml($articleDoc, $article, $journal, $markToDelete = false)
// in OJS2, keywords and subjects where put together into the subject Facet.
// For now, I do the same here. TODO: Decide if this is wanted.
$submissionKeywordDAO = DAORegistry::getDAO('SubmissionKeywordDAO');
$keywords = $submissionKeywordDAO->getKeywords($article->getId(), $supportedLocales);
$keywords = $submissionKeywordDAO->getKeywords($article->getData('currentPublicationId'), $supportedLocales);
foreach($keywords as $locale => $keyword) {
if (empty($keyword)) {
unset($keywords[$locale]);
Expand Down
77 changes: 77 additions & 0 deletions tools/fetchArticle.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,77 @@
<?php

/**
* @file tools/fetchLuceneArticle.php
*
* Copyright (c) 2014-2021 Simon Fraser University
* Copyright (c) 2003-2021 John Willinsky
* Distributed under the GNU GPL v3. For full terms see the file LICENSE.
*
* @class fetchLuceneArticleTool
* @ingroup plugins_generic_lucene
*
* @brief CLI tool to fetch a Lucene document for an article
*/

require(dirname(dirname(dirname(dirname(dirname(__FILE__))))) . '/tools/bootstrap.inc.php');

import('plugins.generic.lucene.LucenePlugin');
import('plugins.generic.lucene.classes.SolrWebService');
import('plugins.generic.lucene.classes.EmbeddedServer');

class fetchLuceneArticleTool extends CommandLineTool {

/**
* Constructor.
* @param $argv array command-line arguments
*/
function __construct($argv = array()) {
parent::__construct($argv);

if (!sizeof($this->argv)) {
$this->usage();
exit(1);
}

$this->parameters = $this->argv;
}

/**
* Print command usage information.
*/
function usage() {
echo _('plugins.generic.lucene.fetchLuceneDoc') . "\n"
. "Usage:\n"
. "{$this->scriptName} submission submission_id [...]\n";
}

/**
* Check citations DOIs
*/
function execute() {
$submissionDao = DAORegistry::getDAO('SubmissionDAO');
$contextDao = Application::getContextDAO();

switch(array_shift($this->parameters)) {
case 'submission':
foreach($this->parameters as $submissionId) {
$submission = $submissionDao->getById($submissionId);
if(!isset($submission)) {
printf("Error: Skipping $submissionId. Unknown submission.\n");
continue;
}
$plugin = PluginRegistry::loadPlugin('generic', 'lucene');
$solrWebService = $plugin->getSolrWebService();
$doc = $solrWebService->getArticleFromIndex($submissionId);
var_dump($doc);
}
break;
default:
$this->usage();
break;
}
}
}

$tool = new fetchLuceneArticleTool(isset($argv) ? $argv : array());
$tool->execute();