Fix keyword indexing: use publication id instead of submission id #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch, @mpbraendle! Are you in a position to forward-port this for 3.4.0? |
|
I haven't 3.4.0 installed yet. Is there only a minor difference? - then I would forward port it - have all branches on my fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyword facets did not work properly on our Lucene/Solr installations. Inspection of the Solr/Lucene index showed that keywords field and facet was missing for many articles that had keywords. This is due to the fact that the submission Id instead of the publication Id was used to extract the keywords from the OJS database.