Update ElfReaderTest's nm usage to be hermetic
#1980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddelnano
commented
Aug 13, 2024
| @@ -110,6 +116,7 @@ filegroup( | |||
| "as", | |||
| "cov", | |||
| "objcopy", | |||
| "nm", | |||
There was a problem hiding this comment.
@JamesMBartlett @vihangm is it possible to get access to a toolchain's other tools? Ideally I'd use the toolchain version of objdump for the test added in #1976 (see discussion linked in this PR's description). Unlike nm and objcopy, which have custom Makefile variables built-in, objdump doesn't have an existing variable.
It seems that TemplateVariableInfo could work for this, but it feels a little strange that it wouldn't be toolchain specific the way @bazel_tools//tools/cpp:current_cc_toolchain is.
3 tasks
oazizi000
approved these changes
Aug 15, 2024
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
Signed-off-by: Dom Del Nano <[email protected]>
ddelnano
force-pushed
the
ddelnano/make-elf-reader-nm-usage-hermetic
branch
from
c456c26
to
8c4f275
Compare
vihangm
approved these changes
Aug 26, 2024
ddelnano
added a commit
to ddelnano/pixie
that referenced
this pull request
Sep 23, 2024
Summary: Update `ElfReaderTest`'s nm usage to be hermetic This was feedback from pixie-io#1976. See [this comment](pixie-io#1976 (comment)) for the previous discussion. Relevant Issues: N/A Type of change: /kind cleanup Test Plan: Elf reader tests pass with updates --------- Signed-off-by: Dom Del Nano <[email protected]> GitOrigin-RevId: 887401c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Update
ElfReaderTest's nm usage to be hermeticThis was feedback from #1976. See this comment for the previous discussion.
Relevant Issues: N/A
Type of change: /kind cleanup
Test Plan: Elf reader tests pass with updates